From 0a6cf70debc6440685af3f9ea96a66450e4f4ed7 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Fri, 7 Jan 2011 22:02:23 -0800 Subject: Rename angular.foreach to angular.forEach to make the api consistent. camelcase is used for other angular functions and forEach is also used by EcmaScript standard. - rename the internal as well as the external function name - tweak the implementation of the function so that it doesn't clober it self when we extend the angular object with an object that has a forEach property equal to this forEach function Closes #85 --- src/Scope.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/Scope.js') diff --git a/src/Scope.js b/src/Scope.js index 393e015b..e1ea43a1 100644 --- a/src/Scope.js +++ b/src/Scope.js @@ -48,7 +48,7 @@ var scopeId = 0, getterFnCache = {}, compileCache = {}, JS_KEYWORDS = {}; -foreach( +forEach( ("abstract,boolean,break,byte,case,catch,char,class,const,continue,debugger,default," + "delete,do,double,else,enum,export,extends,false,final,finally,float,for,function,goto," + "if,implements,import,ininstanceof,intinterface,long,native,new,null,package,private," + @@ -61,7 +61,7 @@ function getterFn(path){ if (fn) return fn; var code = 'var l, fn, t;\n'; - foreach(path.split('.'), function(key) { + forEach(path.split('.'), function(key) { key = (JS_KEYWORDS[key]) ? '["' + key + '"]' : '.' + key; code += 'if(!s) return s;\n' + 'l=s;\n' + @@ -575,7 +575,7 @@ function createScope(parent, providers, instanceCache) { $become: function(Class) { if (isFunction(Class)) { instance.constructor = Class; - foreach(Class.prototype, function(fn, name){ + forEach(Class.prototype, function(fn, name){ instance[name] = bind(instance, fn); }); instance.$service.apply(instance, concat([Class, instance], arguments, 1)); -- cgit v1.2.3