From 575f63ac508a988e0c0ecbf93f62ea6f4bab13c0 Mon Sep 17 00:00:00 2001 From: James Dunn Date: Thu, 3 Oct 2013 10:16:44 +0100 Subject: docs(tutorial): update examples to show best practices Closes #4256, #4255, #4254, #4253, #4250, #4092 --- docs/content/tutorial/step_11.ngdoc | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) (limited to 'docs/content/tutorial/step_11.ngdoc') diff --git a/docs/content/tutorial/step_11.ngdoc b/docs/content/tutorial/step_11.ngdoc index aff35703..8fdd31fb 100644 --- a/docs/content/tutorial/step_11.ngdoc +++ b/docs/content/tutorial/step_11.ngdoc @@ -39,7 +39,7 @@ __`app/index.html`.__ __`app/js/services.js`.__
-angular.module('phonecatServices', ['ngResource']).
+var myApp = angular.module('phonecatServices', ['ngResource']).
factory('Phone', function($resource){
return $resource('phones/:phoneId.json', {}, {
query: {method:'GET', params:{phoneId:'phones'}, isArray:true}
@@ -79,16 +79,12 @@ __`app/js/controllers.js`.__
...
-function PhoneListCtrl($scope, Phone) {
+myApp.controller('PhoneListCtrl', ['$scope', 'Phone', function($scope, Phone) {
$scope.phones = Phone.query();
$scope.orderProp = 'age';
-}
+}]);
-//PhoneListCtrl.$inject = ['$scope', 'Phone'];
-
-
-
-function PhoneDetailCtrl($scope, $routeParams, Phone) {
+myApp.controller('PhoneDetailCtrl', ['$scope', '$routeParams', 'Phone', function($scope, $routeParams, Phone) {
$scope.phone = Phone.get({phoneId: $routeParams.phoneId}, function(phone) {
$scope.mainImageUrl = phone.images[0];
});
@@ -96,9 +92,7 @@ function PhoneDetailCtrl($scope, $routeParams, Phone) {
$scope.setImage = function(imageUrl) {
$scope.mainImageUrl = imageUrl;
}
-}
-
-//PhoneDetailCtrl.$inject = ['$scope', '$routeParams', 'Phone'];
+}]);
Notice how in `PhoneListCtrl` we replaced:
--
cgit v1.2.3