From 6d7e7fdea6c3d6551ff40c150aa42e1375d2cb5f Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Wed, 11 Apr 2012 23:46:23 -0700 Subject: fix($location): properly rewrite urls in html5 mode with base url set previously we were doing all kinds of checks to see if we should rewrite the url or not and we were missing many scenarios. not any more. with this change, we rewrite the url unless: - the href is not set - link has target attribute - the absolute url of the link doesn't match the absolute prefix for all urls in our app This also means that ng-ext-link attribute which we previously used to distinguish external links from app links is not necessary any more. apps can just set target=_self to prevent rewriting. BREAKING CHANGE: ng-ext-link directive was removed because it's unnecessary apps that relied on ng-ext-link should simply replace it with target=_self --- docs/content/cookbook/deeplinking.ngdoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'docs/content/cookbook') diff --git a/docs/content/cookbook/deeplinking.ngdoc b/docs/content/cookbook/deeplinking.ngdoc index 4343ded2..f242f82e 100644 --- a/docs/content/cookbook/deeplinking.ngdoc +++ b/docs/content/cookbook/deeplinking.ngdoc @@ -5,7 +5,7 @@ Deep linking allows you to encode the state of the application in the URL so that it can be bookmarked and the application can be restored from the URL to the same state. -While does not force you to deal with bookmarks in any particular way, it has services +While angular does not force you to deal with bookmarks in any particular way, it has services which make the common case described here very easy to implement. # Assumptions @@ -33,8 +33,8 @@ In this example we have a simple app which consist of two screens: The two partials are defined in the following URLs: -* ./examples/settings.html -* ./examples/welcome.html +* ./examples/settings.html +* ./examples/welcome.html -- cgit v1.2.3