From 3ace81b92ad00da73c89e7536ac7aa7c6681e30a Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Fri, 16 Sep 2011 00:09:33 +0200 Subject: fix(e2e tests): use prop() instead of attr() and quote attributes Because of changes in jQuery, we need to use element().prop() instead of element().attr() to retrieve className and other element properties. Additionally all attribute selectors (e.g. input[name=value]) must have value quoted if it contains dots ("."). --- docs/content/cookbook/advancedform.ngdoc | 2 +- docs/content/cookbook/form.ngdoc | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'docs/content/cookbook') diff --git a/docs/content/cookbook/advancedform.ngdoc b/docs/content/cookbook/advancedform.ngdoc index bbf4875e..585c66a6 100644 --- a/docs/content/cookbook/advancedform.ngdoc +++ b/docs/content/cookbook/advancedform.ngdoc @@ -90,7 +90,7 @@ master.$equals(form)}}">Save expect(element(':button:contains(Cancel)').attr('disabled')).toBeFalsy(); element(':button:contains(Cancel)').click(); expect(element(':button:contains(Cancel)').attr('disabled')).toBeTruthy(); - expect(element(':input[name=form.name]').val()).toEqual('John Smith'); + expect(element(':input[name="form.name"]').val()).toEqual('John Smith'); }); diff --git a/docs/content/cookbook/form.ngdoc b/docs/content/cookbook/form.ngdoc index 08f8971d..2aeafc4d 100644 --- a/docs/content/cookbook/form.ngdoc +++ b/docs/content/cookbook/form.ngdoc @@ -68,18 +68,18 @@ ng:validate="regexp:zip"/>

}); it('should validate zip', function(){ - expect(using('.example').element(':input[name=user.address.zip]').attr('className')) + expect(using('.example').element(':input[name="user.address.zip"]').prop('className')) .not().toMatch(/ng-validation-error/); using('.example').input('user.address.zip').enter('abc'); - expect(using('.example').element(':input[name=user.address.zip]').attr('className')) + expect(using('.example').element(':input[name="user.address.zip"]').prop('className')) .toMatch(/ng-validation-error/); }); it('should validate state', function(){ - expect(using('.example').element(':input[name=user.address.state]').attr('className')) + expect(using('.example').element(':input[name="user.address.state"]').prop('className')) .not().toMatch(/ng-validation-error/); using('.example').input('user.address.state').enter('XXX'); - expect(using('.example').element(':input[name=user.address.state]').attr('className')) + expect(using('.example').element(':input[name="user.address.state"]').prop('className')) .toMatch(/ng-validation-error/); }); -- cgit v1.2.3