From ca865d29a3d4f21601222e43ee49abad5d38ce93 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Tue, 31 Dec 2013 01:36:01 -0800 Subject: test(compileSpec): fix broken build on FF FF 26.0 now throws: "TypeError: NodeList doesn't have an indexed property setter." when we try to assign to `childNodes[1]`, since this test still works properly on Chrome and the issue being tested is not a cross-browser issues, I'm just making the patchability check more robust instead of trying to figure out how to make this test fully pass on FF. --- test/ng/compileSpec.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js index 50aa30ef..2e28f9de 100755 --- a/test/ng/compileSpec.js +++ b/test/ng/compileSpec.js @@ -187,9 +187,14 @@ describe('$compile', function() { if (msie < 9) return; element = jqLite('
{{1+2}}
'); - element[0].childNodes[1] = {nodeType: 3, nodeName: 'OBJECT', textContent: 'fake node'}; - if (!element[0].childNodes[1]) return; //browser doesn't support this kind of mocking + try { + element[0].childNodes[1] = {nodeType: 3, nodeName: 'OBJECT', textContent: 'fake node'}; + } catch(e) { + } finally { + if (!element[0].childNodes[1]) return; //browser doesn't support this kind of mocking + } + expect(element[0].childNodes[1].textContent).toBe('fake node'); $compile(element)($rootScope); -- cgit v1.2.3