From c28662d28dec613876bebacb2df994722c09f3fb Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Tue, 6 Dec 2011 12:20:35 -0800 Subject: fix(filter): remove the $ prefix from filter service ids --- docs/content/guide/dev_guide.forms.ngdoc | 2 +- src/service/filter.js | 10 +++++----- src/service/formFactory.js | 2 +- test/service/parseSpec.js | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/content/guide/dev_guide.forms.ngdoc b/docs/content/guide/dev_guide.forms.ngdoc index d2b81dcc..db2f88cd 100644 --- a/docs/content/guide/dev_guide.forms.ngdoc +++ b/docs/content/guide/dev_guide.forms.ngdoc @@ -286,7 +286,7 @@ This example shows how to implement a custom HTML editor widget in Angular. this.htmlContent = 'Hello World!'; } - HTMLEditorWidget.$inject = ['$element', 'html$Filter']; + HTMLEditorWidget.$inject = ['$element', 'htmlFilter']; function HTMLEditorWidget(element, htmlFilter) { var self = this; diff --git a/src/service/filter.js b/src/service/filter.js index dd97851b..2947d84b 100644 --- a/src/service/filter.js +++ b/src/service/filter.js @@ -30,7 +30,7 @@ * } * * - * The filter function is registered with the `$injector` under the filter name suffixe with `$Filter`. + * The filter function is registered with the `$injector` under the filter name suffixe with `Filter`. *
  *   it('should be the same instance', inject(
  *     function($filterProvider) {
@@ -38,8 +38,8 @@
  *         return ...;
  *       });
  *     },
- *     function($filter, revers$Filter) {
- *       expect($filter('reverse')).toBe(reverse$Filter);
+ *     function($filter, reverseFilter) {
+ *       expect($filter('reverse')).toBe(reverseFilter);
  *     });
  * 
* @@ -76,11 +76,11 @@ */ $FilterProvider.$inject = ['$provide']; function $FilterProvider($provide) { - var suffix = '$Filter'; + var suffix = 'Filter'; function register(name, factory) { return $provide.factory(name + suffix, factory); - }; + } this.register = register; this.$get = ['$injector', function($injector) { diff --git a/src/service/formFactory.js b/src/service/formFactory.js index eb33eb4a..15a4733f 100644 --- a/src/service/formFactory.js +++ b/src/service/formFactory.js @@ -29,7 +29,7 @@ this.html = 'Hello World!'; } - HTMLEditorWidget.$inject = ['$element', 'html$Filter']; + HTMLEditorWidget.$inject = ['$element', 'htmlFilter']; function HTMLEditorWidget(element, htmlFilter) { var self = this; diff --git a/test/service/parseSpec.js b/test/service/parseSpec.js index 85dab72c..f57a52c7 100644 --- a/test/service/parseSpec.js +++ b/test/service/parseSpec.js @@ -198,7 +198,7 @@ describe('parser', function() { expect(function() { scope.$eval("1|nonexistent"); - }).toThrow(new Error("Unknown provider for 'nonexistent$Filter'.")); + }).toThrow(new Error("Unknown provider for 'nonexistentFilter'.")); scope.offset = 3; expect(scope.$eval("'abcd'|substring:1:offset")).toEqual("bc"); -- cgit v1.2.3