From ab3a3bf07a549a80e9230849d08535eca058dbec Mon Sep 17 00:00:00 2001 From: micole Date: Wed, 23 Oct 2013 14:18:29 -0400 Subject: docs(CONTRIBUTING.md): explain we cannot accept localization changes Angular uses the I18N code from Closure library to generate its own localization files. So there is no point submitting pull requests for these files, since all changes would be lost when we next generate these files. Closes #4610 --- CONTRIBUTING.md | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7705d69c..ed029ff1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,7 +4,7 @@ If you have questions about how to use AngularJS, please direct these to the [Google Group][groups] discussion list or [StackOverflow][stackoverflow]. We are also available on [IRC][irc]. -### Guidelines +## Guidelines * Search the archive first, it's likely that your question was already answered. * A live example demonstrating your problem or question, will get an answer faster. @@ -15,18 +15,27 @@ If your issue appears to be a bug, and hasn't been reported, open a new issue. Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues. -[stackoverflow]: http://stackoverflow.com/questions/tagged/angularjs -[groups]: https://groups.google.com/forum/?fromgroups#!forum/angular -[irc]: http://webchat.freenode.net/?channels=angularjs&uio=d4 -[template]: http://plnkr.co/edit/gist:3510140 - ## Contributing to Source Code We'd love for you to contribute to our source code and to make AngularJS even better than it is today! - Please read the [contribution guidelines][contribute] to learn about how to submit code as well as - other useful info like how to build and test AngularJS code. +Please read the [contribution guidelines][contribute] to learn about how to submit code +as well as other useful info like how to build and test AngularJS code. + +### Note to Localization Pull Requests +Angular.js currently uses the +[Google Closure I18N library], to generate its own I18N files. This means that any +changes to these files would be lost the next time that we import the library. The +recommended approach is to submit a patch to the I18N project directly, instead of +submitting it here. + +[Google Closure I18N library]: https://code.google.com/p/closure-library/source/browse/closure/goog/i18n/ [list]: https://groups.google.com/forum/?fromgroups#!forum/angular [contribute]: http://docs.angularjs.org/misc/contribute +[stackoverflow]: http://stackoverflow.com/questions/tagged/angularjs +[groups]: https://groups.google.com/forum/?fromgroups#!forum/angular +[irc]: http://webchat.freenode.net/?channels=angularjs&uio=d4 +[template]: http://plnkr.co/edit/gist:3510140 + -- cgit v1.2.3