From 94dd68570952f6f31abfa351b1159afcd3588a57 Mon Sep 17 00:00:00 2001 From: Misko Hevery Date: Tue, 17 Apr 2012 13:55:10 -0700 Subject: fix(script): Incorrectly reading script text on ie IE deals with script tags in special way and .text() does not work. Reading the .text property directly fixes the issue. --- src/ng/directive/script.js | 7 +++++-- test/ng/directive/scriptSpec.js | 17 ++++++----------- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/src/ng/directive/script.js b/src/ng/directive/script.js index dcbd97b1..79f8b26e 100644 --- a/src/ng/directive/script.js +++ b/src/ng/directive/script.js @@ -35,8 +35,11 @@ var scriptDirective = ['$templateCache', function($templateCache) { terminal: true, compile: function(element, attr) { if (attr.type == 'text/ng-template') { - var templateUrl = attr.id; - $templateCache.put(templateUrl, element.text()); + var templateUrl = attr.id, + // IE is not consistent, in scripts we have to read .text but in other nodes we have to read .textContent + text = element[0].text; + + $templateCache.put(templateUrl, text); } } }; diff --git a/test/ng/directive/scriptSpec.js b/test/ng/directive/scriptSpec.js index 471e04ce..73128765 100644 --- a/test/ng/directive/scriptSpec.js +++ b/test/ng/directive/scriptSpec.js @@ -11,10 +11,6 @@ describe('scriptDirective', function() { it('should populate $templateCache with contents of a ng-template script element', inject( function($compile, $templateCache) { - if (msie <=8) return; - // in ie8 it is not possible to create a script tag with the right content. - // it always comes up as empty. I was trying to set the text of the - // script tag, but that did not work either, so I gave up. $compile('