From 1942861472a4cd8d2d72f2ed54ee2b63be5d68b8 Mon Sep 17 00:00:00 2001 From: Misko Hevery Date: Wed, 24 Aug 2011 21:28:55 -0700 Subject: refactor(hover): delete hover service --- angularFiles.js | 1 - css/angular.css | 62 ----------------------------------------------- src/AngularPublic.js | 1 - src/Browser.js | 36 --------------------------- src/angular-mocks.js | 3 --- src/service/hover.js | 58 -------------------------------------------- test/service/hoverSpec.js | 3 --- 7 files changed, 164 deletions(-) delete mode 100644 src/service/hover.js delete mode 100644 test/service/hoverSpec.js diff --git a/angularFiles.js b/angularFiles.js index b962f562..8e52731b 100644 --- a/angularFiles.js +++ b/angularFiles.js @@ -19,7 +19,6 @@ angularFiles = { 'src/service/defer.js', 'src/service/document.js', 'src/service/exceptionHandler.js', - 'src/service/hover.js', 'src/service/invalidWidgets.js', 'src/service/location.js', 'src/service/log.js', diff --git a/css/angular.css b/css/angular.css index 6c2c52f4..aadd0a31 100644 --- a/css/angular.css +++ b/css/angular.css @@ -19,68 +19,6 @@ border: 2px solid #FF0000; } - -/***************** - * TIP - *****************/ -#ng-callout { - margin: 0; - padding: 0; - border: 0; - outline: 0; - font-size: 13px; - font-weight: normal; - font-family: Verdana, Arial, Helvetica, sans-serif; - vertical-align: baseline; - background: transparent; - text-decoration: none; -} - -#ng-callout .ng-arrow-left{ - background-image: url("data:image/gif;base64,R0lGODlhCwAXAKIAAMzMzO/v7/f39////////wAAAAAAAAAAACH5BAUUAAQALAAAAAALABcAAAMrSLoc/AG8FeUUIN+sGebWAnbKSJodqqlsOxJtqYooU9vvk+vcJIcTkg+QAAA7"); - background-repeat: no-repeat; - background-position: left top; - position: absolute; - z-index:101; - left:-12px; - height:23px; - width:10px; - top:-3px; -} - -#ng-callout .ng-arrow-right{ - background-image: url("data:image/gif;base64,R0lGODlhCwAXAKIAAMzMzO/v7/f39////////wAAAAAAAAAAACH5BAUUAAQALAAAAAALABcAAAMrCLTcoM29yN6k9socs91e5X3EyJloipYrO4ohTMqA0Fn2XVNswJe+H+SXAAA7"); - background-repeat: no-repeat; - background-position: left top; - position: absolute; - z-index:101; - height:23px; - width:11px; - top:-2px; -} - -#ng-callout { - position: absolute; - z-index:100; - border: 2px solid #CCCCCC; - background-color: #fff; -} - -#ng-callout .ng-content{ - padding:10px 10px 10px 10px; - color:#333333; -} - -#ng-callout .ng-title{ - background-color: #CCCCCC; - text-align: left; - padding-left: 8px; - padding-bottom: 5px; - padding-top: 2px; - font-weight:bold; -} - - /***************** * indicators *****************/ diff --git a/src/AngularPublic.js b/src/AngularPublic.js index 8683b379..fc8a90fd 100644 --- a/src/AngularPublic.js +++ b/src/AngularPublic.js @@ -6,7 +6,6 @@ angularService('$browser', function($log, $sniffer) { if (!browserSingleton) { browserSingleton = new Browser(window, jqLite(window.document), jqLite(window.document.body), XHR, $log, $sniffer); - browserSingleton.bind(); } return browserSingleton; }, {$inject: ['$log', '$sniffer']}); diff --git a/src/Browser.js b/src/Browser.js index 62e5b116..ed12441a 100644 --- a/src/Browser.js +++ b/src/Browser.js @@ -415,42 +415,6 @@ function Browser(window, document, body, XHR, $log, $sniffer) { ////////////////////////////////////////////////////////////// // Misc API ////////////////////////////////////////////////////////////// - var hoverListener = noop; - - /** - * @workInProgress - * @ngdoc method - * @name angular.service.$browser#hover - * @methodOf angular.service.$browser - * - * @description - * Set hover listener. - * - * @param {function(Object, boolean)} listener Function that will be called when a hover event - * occurs. - */ - self.hover = function(listener) { hoverListener = listener; }; - - /** - * @workInProgress - * @ngdoc method - * @name angular.service.$browser#bind - * @methodOf angular.service.$browser - * - * @description - * Register hover function to real browser - */ - self.bind = function() { - document.bind("mouseover", function(event){ - hoverListener(jqLite(msie ? event.srcElement : event.target), true); - return true; - }); - document.bind("mouseleave mouseout click dblclick keypress keyup", function(event){ - hoverListener(jqLite(event.target), false); - return true; - }); - }; - /** * @workInProgress diff --git a/src/angular-mocks.js b/src/angular-mocks.js index a39fd7bf..731c2c29 100644 --- a/src/angular-mocks.js +++ b/src/angular-mocks.js @@ -328,9 +328,6 @@ MockBrowser.prototype = { return pollFn; }, - hover: function(onHover) { - }, - url: function(url, replace) { if (url) { this.$$url = url; diff --git a/src/service/hover.js b/src/service/hover.js deleted file mode 100644 index f8470370..00000000 --- a/src/service/hover.js +++ /dev/null @@ -1,58 +0,0 @@ -'use strict'; - -/** - * @workInProgress - * @ngdoc service - * @name angular.service.$hover - * @requires $browser - * @requires $document - * - * @description - * - * @example - */ -angularServiceInject("$hover", function(browser, document) { - var tooltip, self = this, error, width = 300, arrowWidth = 10, body = jqLite(document[0].body); - browser.hover(function(element, show){ - if (show && (error = element.attr(NG_EXCEPTION) || element.attr(NG_VALIDATION_ERROR))) { - if (!tooltip) { - tooltip = { - callout: jqLite('
'), - arrow: jqLite('
'), - title: jqLite('
'), - content: jqLite('
') - }; - tooltip.callout.append(tooltip.arrow); - tooltip.callout.append(tooltip.title); - tooltip.callout.append(tooltip.content); - body.append(tooltip.callout); - } - var docRect = body[0].getBoundingClientRect(), - elementRect = element[0].getBoundingClientRect(), - leftSpace = docRect.right - elementRect.right - arrowWidth; - tooltip.title.text(element.hasClass("ng-exception") ? "EXCEPTION:" : "Validation error..."); - tooltip.content.text(error); - if (leftSpace < width) { - tooltip.arrow.addClass('ng-arrow-right'); - tooltip.arrow.css({left: (width + 1)+'px'}); - tooltip.callout.css({ - position: 'fixed', - left: (elementRect.left - arrowWidth - width - 4) + "px", - top: (elementRect.top - 3) + "px", - width: width + "px" - }); - } else { - tooltip.arrow.addClass('ng-arrow-left'); - tooltip.callout.css({ - position: 'fixed', - left: (elementRect.right + arrowWidth) + "px", - top: (elementRect.top - 3) + "px", - width: width + "px" - }); - } - } else if (tooltip) { - tooltip.callout.remove(); - tooltip = null; - } - }); -}, ['$browser', '$document'], true); diff --git a/test/service/hoverSpec.js b/test/service/hoverSpec.js deleted file mode 100644 index 429d26d2..00000000 --- a/test/service/hoverSpec.js +++ /dev/null @@ -1,3 +0,0 @@ -'use strict'; - - -- cgit v1.2.3