aboutsummaryrefslogtreecommitdiffstats
path: root/src
AgeCommit message (Collapse)Author
2014-02-11docs(core): add closing tag to ngApp directive exampleJesse Palmer
added missing closing tag to ngApp example. Closes #6066
2014-02-11docs(jqLite): link to jQuery.fn.bind/unbind docs rather than ↵Evgeniy Tkachenko
jQuery.fn.on/off docs Сorrect link. Closes #6171
2014-02-11feat(filterFilter): support deeply nested predicate objectsCaitlin Potter
Due to 339a165, it became impossible to filter nested properties of an object using the filterFilter. A proposed solution to this was to enable the use of nested predicate objects. This change enables the use of these nested predicate objects. Example: ```html <div ng-repeat="it in items | filter:{ address: { country: 'Canuckistan'}}"></div> ``` Or ```js $filter('filter')(items, { address: { country: 'Canuckistan' } }); ``` Closes #6215 Related to #6009
2014-02-11refactor(ngTransclude): use transclusion function passed in to linkDaniel Tabuenca
Since we now pass in the transclusion function directly to the link function, we no longer need the old scheme whereby we saved the transclude function injected into the controller for later use in during linking. Additionally, this change may aid in correcting a memory leak of detached DOM nodes (see #6181 for details). This commit removes the controller and simplifies ngTransclude. Closes #5375 Closes #6181
2014-02-10docs(ngSubmit): ngSubmit also works with the `data-action`/`x-action` attributesJames Wagoner
The documentation states only the "action" attribute triggers this, which is incorrect. When using the attribute "data-action" (as for AJAX control, attempting to bypass the "action" attribute but still make it obvious what its for), Angular thinks this is also classified as "action" and continues with the page submission. Closes #6196
2014-02-10fix($compile): ensure element transclusion directives are linked with ↵Caitlin Potter
comment element This corrects a complicated compiler issue, described in detail below: Previously, if an element transclusion directive contained an asynchronous directive whose template contained another element transclusion directive, the inner element transclusion directive would be linked with the element, rather than the expected comment node. An example manifestation of this bug would look like so: ```html <div ng-repeat="i in [1,2,3,4,5]"> <div my-directive> </div> </div> ``` `my-directive` would be a replace directive, and its template would contain another element transclusion directive, like so: ```html <div ng-if="true">{{i}}</div> ``` ngIf would be linked with this template content, rather than the comment node, and the template element would be attached to the DOM, rather than the comment. As a result, this caused ng-if to duplicate the template when its expression evaluated to true. Closes #6006 Closes #6101
2014-02-07revert: refactor(mocks): simplify the `inject` implementationIgor Minar
This reverts commit 64d58a5b5292046adf8b28928950858ab3895fcc. For some weird reason this is causing regressions at Google. I'm not sure why and I'm running out of time to investigate, so I'm taking a safe route here and reverting the commit since it's just a refactoring.
2014-02-06chore(testing): de-flake a ngHref test for navigating away from the Angular pageJulie
2014-02-06fix($locale): Minor grammar amends for locale_ltKasparas Galdikas
Closes #6164
2014-02-06docs(injector): correct typo in examplesunderls
$provide misused into $provider maybe this should be corrected I think Closes #6146
2014-02-06fix(mocks): rename mock.animate to ngAnimateMock and ensure it contains all ↵Matias Niemelä
test helper code for ngAnimate Closes #5822 Closes #5917
2014-02-06fix(mocks): remove usage of $animate.flushNext in favour of queingMatias Niemelä
The flushNext method of testing is difficult and highly coupled with the behavior of ngAnimate's $animate workflow. It is much better instead to just queue all $animate animation calls into a queue collection which is available on the $animate service when mock.animate is included as a module within test code.
2014-02-05docs(angular.forEach): add missing space in testFranziskus Domig
Closes #6130
2014-02-05chore(testing): run end to end tests on firefox and safari as well as chromeJulie
Update the Travis and Jenkins configs to run protractor tests on Safari and Firefox as well, and make the Travis tests run output XML and turn off color. Fix tests which were failing in Firefox due to clear() not working as expected. Fix tests which were failing in Safari due to SafariDriver not understanding the minus key, and disable tests which SafariDriver has no support for.
2014-02-05docs(forEach): correct spelling errorHopiu
Closes #6124
2014-02-04fix(ngMock): return false from mock $interval.cancel() when no argument is ↵Daniel Luxemburg
supplied Closes #6103. Closed #6099.
2014-02-04fix(jqLite): trim HTML string in jqLite constructorCaitlin Potter
jQuery will construct DOM nodes containing leading whitespace. Prior to this change, jqLite would throw a nosel minErr due to the first character of the string not being '<'. This change corrects this behaviour by trimming the element string in jqLite constructor before testing for '<'. Closes #6053
2014-02-04fix($http): ignore xhr.responseType setter exception if value is "json"Caitlin Potter
WebKit added support for the json responseType value on 09/03/2013 https://bugs.webkit.org/show_bug.cgi?id=73648. Versions of Safari prior to 7 are known to throw when setting the value "json" as the response type. Other older browsers implementing the responseType. Other browsers with infrequent update cycles may also be affected. The json responseType value can be ignored if not supported, because JSON payloads are parsed on the client-side regardless. Closes #6115 Closes #6122
2014-02-04docs(log.js): param debugEnabled is a boolean and not a stringGiffenGood
2014-02-04revert: "fix($http): ignore xhr.responseType setter exception if value is ↵Caitlin Potter
"json"" This reverts commit 431bad01835f0294eb159d5b08101d5904828147.
2014-02-04fix($http): ignore xhr.responseType setter exception if value is "json"Caitlin Potter
WebKit added support for the json responseType value on 09/03/2013 https://bugs.webkit.org/show_bug.cgi?id=73648. Versions of Safari prior to 7 are known to throw when setting the value "json" as the response type. Other older browsers implementing the responseType. Other browsers with infrequent update cycles may also be affected. The json responseType value can be ignored if not supported, because JSON payloads are parsed on the client-side regardless. Closes #6115 Closes #6122
2014-02-04fix(ngResource): don't filter "$"-prefixed properties from ngResource ↵Thomas Belin
requests/responses ngResource no longer filters properties prefixed with a single "$" character from requests or responses, correcting a regression introduced in 1.2.6 (cb29632a) which caused shallowCopy and shallowClearAndCopy to ignore properties prefixed with a single "$". Closes #5666 Closes #6080 Closes #6033
2014-02-04docs($compile): fixed syntax error.Kamil Pekala
"how to" was written twice in a row. Closes #6110
2014-02-04docs($q): fixed grammatical errorJohn Kurlak
"Promises" should be of the possessive form. Closes #6082
2014-02-03refactor(mocks): simplify the implementationIgor Minar
2014-02-03fix(mocks): always call functions injected with `inject` with `this` set to ↵Wes Alvaro
the current spec Currently when a function is injected inside of a test we set the context to undefined which is a bug. Closes #6102
2014-02-03chore(ngClass): remove debugger statement from an e2e testIgor Minar
2014-02-03fix(ngResource): don't append number to '$' in url param value when encoding URICaitlin Potter
Previously, if a URL parameter value included a $, it would replace the dollar sign with a literal '$1' for mysterious reasons. Using a function rather than a replacement string circumvents this behaviour and produces a more expected result. Closes #6003 Closes #6004
2014-01-31fix(http): make jshint happyIgor Minar
2014-01-31fix($http): update httpBackend to use ActiveXObject on IE8 if necessaryJorg
window.XMLHttpRequest is not always available in IE8 despite it not running in quirks mode, in which case Angular should be using the ActiveXObject instead. Just checking the browser version is taking too many shortcuts. Closes #5677 Closes #5679
2014-01-31fix($q): make $q.reject support `finally` and `catch`Lucas Galfasó
Add support for the functions `finally` and `catch` to the promise returned by `$q.reject` Closes #6048 Closes #6076
2014-01-31fix($compile): retain CSS classes added in cloneAttachFn on asynchronous ↵Caitlin Potter
directives Previously, classes added to asynchronous directive elements during the clone attach function would not persist after the node is merged with the template, prior to linking. This change corrects this behaviour and brings it in line with synchronous directives. Closes #5439 Closes #5617
2014-01-31fix(filterFilter): don't interpret dots in predicate object fields as pathsIgor Minar
Closes #6005 Closes #6009
2014-01-30Edited the 'Flushing HTTP requests' sectionShawn Flahave
Minor grammatical edits in the Flushing HTTP requests section.
2014-01-30fix(docs): clarify doc for "args" in $broadcast and $emitBrad Williams
Closes #6047.
2014-01-29docs($provide): return instance of Ping, rather than constructorClark Pan
Updating $provide.service method docs The previous example provided for the service method did not work. I've updated the example to a working example. I think this version of the example will probably make more sense to most people, and the factory method would be a better place for this sort of example. Closes #6008
2014-01-28test(docs): convert example end to end doc tests from scenario runner to ↵Julie
protractor Thanks to jeffbcross, petebacondarwin, btford, jdeboer, tbosch for contributions! Closes #6023
2014-01-27fix(mocks): refactor currentSpec to work w/ Jasmine 2John Papa
Closes #5662
2014-01-26docs(select): rephase note on ngOptionsDavid Nelson
added 'an' and 'the' to ngOptions sentence Closes #5993
2014-01-26docs(ngSwitch): fixed typo 'choses' to 'chooses'David Nelson
Closes #5992
2014-01-24feat($animate): provide support for a close callbackMatias Niemelä
Closes #5685 Closes #5053 Closes #4993
2014-01-23docs(ngdoc): ensure module installation docs are accuratePeter Bacon Darwin
The ngMock module is built into a package called angular-mocks, which is not named consistently and the docs were giving invalid info. Closes #5810
2014-01-22fix(a): don't preventDefault on click when SVGAElement has an xlink:href ↵Caitlin Potter
attribute Before this change, an SVGAElement with an xlink:href attribute and no href or name attribute which was compiled by the angular HTML compiler would never be clickable, due to the htmlAnchorDirective calling event.preventDefault() due to the missing href attribute. This change corrects this behaviour by also testing the xlink:href attribute if the element in question is determined to be an SVG anchor tag (with the href property having type SVGAnimatedString) Closes #5896 Closes #5897
2014-01-22docs(ngRoute): grammar correctionAllon Hadaya
grammar: occurs -> occur Closes #5937
2014-01-22style($interval): remove ws and replace comma with semicolonIgor Minar
2014-01-22docs(ngMock): $log.error property contains messages from $log.error, not ↵gabrielbrasil
$log.log Closes #5932
2014-01-21fix(input): use Chromium's email validation regexpCaitlin Potter
This change uses the regexp from Chromium/Blink to validate emails, and corrects an error in the validation engine, which previously considered an invalid email to be valid. Additionally, the regexp was invalidating emails with capital letters, however this is not the behaviour recomended in the spec, or implemented in Chromium. Closes #5899 Closes #5924
2014-01-21docs(select): add callout style for a noteBrian Ford
2014-01-21docs(select): add object comparison warningDan Matthews
2014-01-21fix(ngRoute): pipe preceding route param no longer masks ? or * operatorCaitlin Potter
Before this change, ```js $routeProvider.when('/foo/:bar|?', { ... }); ``` would not have the expected effect --- the parameter would not be optional, and the pipe would not be included in the parameter name. Following this change, the presence of the pipe operator will typically cause an exception to be thrown due to the fact that the generated regexp is invalid. The net result of this change is that ? and * operators will not be masked, and pipe operators will need to be removed, although it's unexpected that these are being used anywhere. Closes #5920