aboutsummaryrefslogtreecommitdiffstats
path: root/src/ng/directive
AgeCommit message (Collapse)Author
2014-02-16chore(protractor tests): fix up e2e testsJulie
2014-02-16chore(protractor-generator): add dgeni processor for protractorJulie
2014-02-16docs(bike-shed-migration): fix url-based links refs to AUTO modulePeter Bacon Darwin
2014-02-16docs(bike-shed-migration): fix invalid </file name=""> HTML in examplesPeter Bacon Darwin
2014-02-16docs(bike-shed-migration): let markdown deal with extenal linksPeter Bacon Darwin
It is problematic to use {@link} tags with external links because the markdown parser converts them to links for us before we parse the @links. This means that the following tag: ``` {@link http://www.google.com Google} ``` get converted to: ``` {@link <a href="http://www.google.com/"></a> Google} ``` Our {@link} parser then converts this to: ``` <a href="<a">&lt;</a>href="http://www.google.com/"></a> Google} ``` which is clearly a mess. The best solution is not to use {@link} tags for external links and just use the standard markdown syntax: ``` [Google](http://www.google.com) ``` In the long run, we could look into configuring or modifying `marked` not to convert these external links or we could provide a "pre-parser" processor that dealt with such links before `marked` gets its hands on it.
2014-02-16docs(bike-shed-migration): convert <doc:...> examples to <example>...Peter Bacon Darwin
2014-02-16docs(all): convert <pre>/</pre> snippets to GFM snippetsCaitlin Potter
2014-02-16docs(bike-shed-migration): convert doctype and namesPeter Bacon Darwin
2014-02-13fix(input): don't apply textInput to <input type="file">Tim Whitbeck
textInput shouldn't be applied to file inputs to ease writing of custom file input directives. This change prevents file inputs from instantiating the text input parser/formatter pipelines. Closes #6247 Closes #6231
2014-02-12fix(input): setViewValue on compositionendCaitlin Potter
Because of a4e6d962, model is not updated on input/change between the compositionstart and compositionend events. Unfortunately, the compositionend event does not always happen prior to an input/change event. This changeset calls the listener function to update the model after a compositionend event is received. Closes #6058 Closes #5433
2014-02-12docs(input): document NgModelController.$isEmpty parameters / return valueMathieu Tricoire
Closes #6224
2014-02-11refactor(ngTransclude): use transclusion function passed in to linkDaniel Tabuenca
Since we now pass in the transclusion function directly to the link function, we no longer need the old scheme whereby we saved the transclude function injected into the controller for later use in during linking. Additionally, this change may aid in correcting a memory leak of detached DOM nodes (see #6181 for details). This commit removes the controller and simplifies ngTransclude. Closes #5375 Closes #6181
2014-02-10docs(ngSubmit): ngSubmit also works with the `data-action`/`x-action` attributesJames Wagoner
The documentation states only the "action" attribute triggers this, which is incorrect. When using the attribute "data-action" (as for AJAX control, attempting to bypass the "action" attribute but still make it obvious what its for), Angular thinks this is also classified as "action" and continues with the page submission. Closes #6196
2014-02-06chore(testing): de-flake a ngHref test for navigating away from the Angular pageJulie
2014-02-05chore(testing): run end to end tests on firefox and safari as well as chromeJulie
Update the Travis and Jenkins configs to run protractor tests on Safari and Firefox as well, and make the Travis tests run output XML and turn off color. Fix tests which were failing in Firefox due to clear() not working as expected. Fix tests which were failing in Safari due to SafariDriver not understanding the minus key, and disable tests which SafariDriver has no support for.
2014-02-03chore(ngClass): remove debugger statement from an e2e testIgor Minar
2014-01-28test(docs): convert example end to end doc tests from scenario runner to ↵Julie
protractor Thanks to jeffbcross, petebacondarwin, btford, jdeboer, tbosch for contributions! Closes #6023
2014-01-26docs(select): rephase note on ngOptionsDavid Nelson
added 'an' and 'the' to ngOptions sentence Closes #5993
2014-01-26docs(ngSwitch): fixed typo 'choses' to 'chooses'David Nelson
Closes #5992
2014-01-22fix(a): don't preventDefault on click when SVGAElement has an xlink:href ↵Caitlin Potter
attribute Before this change, an SVGAElement with an xlink:href attribute and no href or name attribute which was compiled by the angular HTML compiler would never be clickable, due to the htmlAnchorDirective calling event.preventDefault() due to the missing href attribute. This change corrects this behaviour by also testing the xlink:href attribute if the element in question is determined to be an SVG anchor tag (with the href property having type SVGAnimatedString) Closes #5896 Closes #5897
2014-01-21fix(input): use Chromium's email validation regexpCaitlin Potter
This change uses the regexp from Chromium/Blink to validate emails, and corrects an error in the validation engine, which previously considered an invalid email to be valid. Additionally, the regexp was invalidating emails with capital letters, however this is not the behaviour recomended in the spec, or implemented in Chromium. Closes #5899 Closes #5924
2014-01-21docs(select): add callout style for a noteBrian Ford
2014-01-21docs(select): add object comparison warningDan Matthews
2014-01-19docs(ngEventDirs): document priority of event directivesAbraham
The general assumption is that if @priority is not defined, the priority is 0. BUT it's not necessarily harmful to be explicit about this. Closes #5852
2014-01-18docs(ngInit): ng-init is an attribute/class directive, not an element directiveBastian Buchholz
As discussed in comments on https://github.com/angular/angular.js/commit/42ec95ebae716c81087684b55ed8fa8c13888abc#commitcomment-5109829, ngInit is not an element directive, so @clkao's example should reflect this. Closes #5879
2014-01-18docs(ngInit): note precedence when used with filtersChia-liang Kao
Clears up expression priority issue Closes #3869 Closes #5873
2014-01-17docs(input): document ngValue directiveAbdessamad Idrissi
Extend the example with ng-value showing how to deal with default checked radio boxes. Closes #5654
2014-01-17docs(ngChange): clarify difference between ng-change DOM change eventAndreas Gruenbacher
The ng-change event triggers immediately, which makes a difference for text input fields and text areas, where the JavaScript onchange event would only be called at the end of the change. Closes #5640
2014-01-15docs(ngShowHide): make a note of values considered to be falsyFoxandxss
This issue has been a focus of problems for some users and we discussed it on the IRC that it should be at least documented. ~Amended the style to use bootstrap notes, I think overall it looks better and catches the eyes more easily. However there are no anchor links to these, if these are necessary they can be added later. Closes #3436 Closes #5762
2014-01-10docs(select): update regexp grouping cheat-sheatAjay Roopakalu
Update the regexp grouping comment to reflect the changes needed for multiline expressions in ng-options for <select>. Closes #5602
2014-01-10feat(select): allow multiline ng-optionsAjay Roopakalu
This patch allows the ng-options value of a <select> element to span multiple lines, which would previously throw an error when used with filters. Closes #5602
2014-01-08feat(docs): adding the <doc:protractor> ngdoc-tagJulie
This is the first step in migrating tests from <doc:scenario> to <doc:protractor>. In-documentation examples with doc:protractor sections will have their contents output to a tab on the docs site as well as output to a standalone test file in build/docs/ptore2e.
2014-01-08docs(script): add more detailed informationGias Kay Lee
Closes #5671 Closes #5676
2014-01-07refactor(booleanAttrs, ngSwitch): use link function instead of compile ↵Gias Kay Lee
function where appropriate Replace two compile functions that immediately return a post-link function with link function definitions instead. Closes #5664
2014-01-06refactor(input): wrapped validation logic in helper functionBen Wiklund
Closes #5643
2014-01-06docs(form): changed capitalization in CSS classes sectionjesse
In order to improve readability from "Is set" (confused on my screen as 'Ls set') updated the capitalization describing the setting of 4 CSS classes. Closes #5642
2014-01-03docs(ngRepeat): add info about aliasing special properties of ngRepeatWojciech Krzystek
This will safe peoples' time, since ngRepeat's docs, not ngInit's, is the first place where one would search for such info. Closes #5622
2014-01-02fix(ngRepeat): allow for more flexible coding style in ngRepeat expressionGias Kay Lee
With this change it's possible to split the ng-repeat expression into multiple lines at any point in the expression where white-space is expected. Closes #5537 Closes #5598
2013-12-31fix(input): use apply on change event only when one isn't already in progressIgor Minar
Closes #5293
2013-12-30fix(input): prevent double $digest when using jQuery trigger.Michał Gołębiowski
If an event was performed natively, jQuery sets the isTrigger property. When triggering event manually, the field is not present. Manually triggered events are performed synchronously which causes the "$digest already in progress" error. Closes #5293
2013-12-19docs(ngCloak): style name is ng-cloak, not ngCloaksnicolai
Closes #5374
2013-12-19docs(booleanAttrs): add @priority to all the boolean directivesMark Jones
Closes #5361
2013-12-19docs(ngEventDirs): adding quick examples for new eventsJames Watling
Closes #5338
2013-12-18docs(ngInit): fix typoJason Farnsworth
Closes #5343
2013-12-18fix(input): do not hold input for composition on androidChia-liang Kao
Workaround for chrome for android until #2129 is ready. Closes #5308, #5323
2013-12-17fix(select): invalidate when 'multiple`, `required` and model is `[]`Caitlin Potter
When `multiple` attribute is set on a `<select>` control and the model value is an empty array, we should invalidate the control. Previously, this directive was using incorrect logic for determining if the model was empty. Closes #5337
2013-12-17docs(ngIf): remove invalid comment from CSSPete Bacon Darwin
We cannot use valid /* ... */ CSS comments in examples because they break the parsing of the ngdoc comments. We can't use inline // comments because these are not valid in CSS. We could use the //!annotate extension to the ngdoc parser but this does not seem to be working. It is best to simply remove this line. Closes #5234
2013-12-16fix(ngRepeat): allow multiline expressionsRhys Brett-bowen
allow and pass through new line characters when checking passed in expression Closes #5000
2013-12-13perf(jqLite): implement and use the `empty` method in place of `html(‘’)`Michał Gołębiowski
jQuery's elem.html('') is way slower than elem.empty(). As clearing element contents happens quite often in certain scenarios, switching to using .empty() provides a significant performance boost when using Angular with jQuery. Closes #4457
2013-12-13perf(a): do not link when href or name exists in templateKarl Seamon
Change the a directive to link and hookup a click event only when there is no href or name in the template element. In a large Google app, this results in about 800 fewer registrations, saving a small but measurable amount of time and memory. Closes #5362