aboutsummaryrefslogtreecommitdiffstats
path: root/src/ng/directive/input.js
AgeCommit message (Collapse)Author
2014-01-28test(docs): convert example end to end doc tests from scenario runner to ↵Julie
protractor Thanks to jeffbcross, petebacondarwin, btford, jdeboer, tbosch for contributions! Closes #6023
2014-01-21fix(input): use Chromium's email validation regexpCaitlin Potter
This change uses the regexp from Chromium/Blink to validate emails, and corrects an error in the validation engine, which previously considered an invalid email to be valid. Additionally, the regexp was invalidating emails with capital letters, however this is not the behaviour recomended in the spec, or implemented in Chromium. Closes #5899 Closes #5924
2014-01-17docs(input): document ngValue directiveAbdessamad Idrissi
Extend the example with ng-value showing how to deal with default checked radio boxes. Closes #5654
2014-01-17docs(ngChange): clarify difference between ng-change DOM change eventAndreas Gruenbacher
The ng-change event triggers immediately, which makes a difference for text input fields and text areas, where the JavaScript onchange event would only be called at the end of the change. Closes #5640
2014-01-06refactor(input): wrapped validation logic in helper functionBen Wiklund
Closes #5643
2013-12-31fix(input): use apply on change event only when one isn't already in progressIgor Minar
Closes #5293
2013-12-30fix(input): prevent double $digest when using jQuery trigger.Michał Gołębiowski
If an event was performed natively, jQuery sets the isTrigger property. When triggering event manually, the field is not present. Manually triggered events are performed synchronously which causes the "$digest already in progress" error. Closes #5293
2013-12-18fix(input): do not hold input for composition on androidChia-liang Kao
Workaround for chrome for android until #2129 is ready. Closes #5308, #5323
2013-12-09docs(input): remove redundant closing span tagmiknsh5
Closes #5257
2013-12-04fix(input): ensure ngModelWatch() triggers second digest pass when appropriateDaniel Tabuenca
Due to an earlier change, ngModelWatch() no longer returns a value to the caller. This means the digest loop has no way to tell if the watch actually modified anything and so can not schedule another pass. This means any watches that watch form or model controller changes (e.g. watches on form.$valid) that are scheduled prior to an ngModelWatch() will not be able to see any changes made therin. This commit fixes this behavior by returning the latest evaluated ng-model value. Closes #5258 Closes #5282
2013-12-04docs(input): remove deprecated isolated scope pitfallJulien Bouquillon
The 1.2 release fixed the documented pitfall at 909cabd36d779598763cc358979ecd85bb40d4d7 by isolating only the isolated directive's scope. Closes #5179
2013-11-22fix(input): Support form auto complete on modern browserTobias Bosch
Although modern browser support the "input" event, they still only fire the "change" event when they auto complete form elements other than the currently selected one. Related to #1460
2013-11-21feat(input): hold listener during text compositionChia-liang Kao
When composing text in CJKV, intermediate buffer for unfinished text should not be updating the bound scope variables. Closes #4684
2013-11-14docs(NgModelController): document `$viewChangeListeners` propertyCaitlin Potter
Closes #4948
2013-11-14docs(NgModelController): clarify documentation of `$setViewValue`Mathis Hofer
$setViewValue does not really "Read a value from view". It should be called to trigger the ngModel to be updated when the value in the view changes. Closes #4907
2013-11-04docs(input): fix typoTim Graham
Closes #4734
2013-11-04fix(ngModel): deregister from the form on scope not DOM destructionIgor Minar
Due to animations, DOM might get destroyed much later than scope and so the element $destroy event might get fired outside of $digest, which causes changes to the validation model go unobserved until the next digest. By deregistering on scope event, the deregistration always happens in $digest and the form validation model changes will be observed. Closes #4226 Closes #4779
2013-11-04style: remove wsIgor Minar
2013-10-24docs(ngModelController): $parent can help isolate scope directivesbasarat
2013-10-24fix(input): keep track of min/max attars on-the-flyDmitry Shirokov
Now input[type=button] keeps track of both min and max attrs even if they change over time.
2013-10-22style: make jshint happyVojta Jina
2013-10-18docs: correct broken linksVojta Jina
This also contains some whitespace corrections by my editor.
2013-10-07fix(input): `false` is no longer an empty value by defaultPete Bacon Darwin
`checkboxInputType` and `ngList` directives need to have special logic for whether they are empty or not. Previously this had been hard coded into their own directives or the `ngRequired` directive. This made it difficult to handle these special cases. This change factors out the question of whether an input is empty into a method `$isEmpty` on the `ngModelController`. The `ngRequired` directive now uses this method when testing for validity and directives, such as `checkbox` or `ngList` can override it to apply logic specific to their needs. Closes #3490, #3658, #2594
2013-10-07docs(ngModel): fix grammar and improve clarityDave Peticolas
Closes #4291
2013-10-07docs(ngValue): add docs for ngValue directiveBrian Ford
Closes #4267
2013-10-05docs(ngList): improve grammar and clarityDave Peticolas
2013-10-03fix($compile): fix (reverse) directive postLink fn execution orderIgor Minar
previously the compile/link fns executed in this order controlled via priority: - CompilePriorityHigh, CompilePriorityMedium, CompilePriorityLow - PreLinkPriorityHigh, PreLinkPriorityMedium, PreLinkPriorityLow - link children - PostLinkPriorityHigh, PostLinkPriorityMedium, PostLinkPriorityLow This was changed to: - CompilePriorityHigh, CompilePriorityMedium, CompilePriorityLow - PreLinkPriorityHigh, PreLinkPriorityMedium, PreLinkPriorityLow - link children - PostLinkPriorityLow, PostLinkPriorityMedium , PostLinkPriorityHigh Using this order the child transclusion directive that gets replaced onto the current element get executed correctly (see issue #3558), and more generally, the order of execution of post linking function makes more sense. The incorrect order was an oversight that has gone unnoticed for many suns and moons. (FYI: postLink functions are the default linking functions) BREAKING CHANGE: the order of postLink fn is now mirror opposite of the order in which corresponding preLinking and compile functions execute. Very few directives in practice rely on order of postLinking function (unlike on the order of compile functions), so in the rare case of this change affecting an existing directive, it might be necessary to convert it to a preLinking function or give it negative priority (look at the diff of this commit to see how an internal attribute interpolation directive was adjusted). Closes #3558
2013-09-19docs(ngModelController): clarify issue with isolated scope directivePete Bacon Darwin
See #4043
2013-09-19docs(input): fix spelling error and reword for clarityts-web
2013-09-17docs(input): clarify that `contenteditable` is an HTML5 attributeJames
Closes #3841
2013-09-11docs(ngModel): provide link for best practices.Paxton Hare
Closes #3973
2013-09-11docs(ngChange): remove wrong @restrict and add missing @paramrodyhaddad
2013-08-09docs(ngModel): validators should return undefined for invalid values.Niall Smart
Closes #3525
2013-08-08docs(ngModel): clarify docs for NgModelController#Igor Minar
Closes #3498
2013-08-08docs(ngModel): add link to NgModelControllerIgor Minar
2013-08-07docs(minerr): fill in error message descriptionsKen Sheedlo
Errors I've documented so far: - `$injector:cdep` - `$injector:itkn` - `$injector:modulerr` - `$injector:nomod` - `$injector:pget` - `$injector:unpr` - `ng:areq` - `ng:cpi` - `ng:cpws` - `ngModel:noass` Closes #3430
2013-08-07fix(input): fix the email regex to accept TLDs up to 6 characters longneilmcgibbon
The input field email regex does't not match long domain extensions. This commit extends the email regexp to take a 6 character TLD. Example 6-character TLDs include .museum and .travel - (e.g. allabout.travel).
2013-07-21docs(input): fix exampleJérémy
The input [number] error spans did not show on the example, as they were relying on an non-existing property (myForm.list.$error) vs the working property (myForm.input.$error)
2013-07-11fix(ngValue): made ngValue to write value attribute to elementMikk Kirstein
2013-07-11docs(ngList): fix example and add e2e testIgor Minar
2013-07-10style(input): remove wsIgor Minar
2013-07-08docs(ngModelController): provide a more intuitive examplePete Bacon Darwin
The example directive, using contenteditable was not showing required even if you cleared the content from it. Closes #3156
2013-07-04docs(input): ng-model doesn't work well with isolated scope directivebasarat
Closes #3123
2013-06-19feat(jqLite): switch bind/unbind to more recent jQuery on/offMichał Gołębiowski
jQuery switched to a completely new event binding implementation as of 1.7.0, centering around on/off methods instead of previous bind/unbind. This patch makes jqLite match this implementation while still supporting previous bind/unbind methods.
2013-06-17chore(minErr): replace ngError with minErrKen Sheedlo
2013-06-12docs(ngModelController): improve $parsers/$formatters with exampleDean Peterson
2013-06-04docs(input): provide explanation of how ngModel will affect the local scopeLuc Morin
2013-05-24feat(ngError): add error message compression and better error messagesIgor Minar
- add toThrowNg matcher
2013-05-23docs(input): add missing ngChange directive for email typeDavid Bennett
All other input types already have it.
2013-05-18doc(ngModel): $setViewValue calls all parsers, not formattersJoakim Blomskøld