aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--src/ng/compile.js16
-rwxr-xr-xtest/ng/compileSpec.js64
2 files changed, 72 insertions, 8 deletions
diff --git a/src/ng/compile.js b/src/ng/compile.js
index 04689268..8b7a7674 100644
--- a/src/ng/compile.js
+++ b/src/ng/compile.js
@@ -621,13 +621,6 @@ function $CompileProvider($provide) {
directiveName = directive.name;
- if (directiveValue = directive.controller) {
- controllerDirectives = controllerDirectives || {};
- assertNoDuplicate("'" + directiveName + "' controller",
- controllerDirectives[directiveName], directive, $compileNode);
- controllerDirectives[directiveName] = directive;
- }
-
if (directiveValue = directive.transclude) {
assertNoDuplicate('transclusion', transcludeDirective, directive, $compileNode);
transcludeDirective = directive;
@@ -705,6 +698,13 @@ function $CompileProvider($provide) {
}
}
+ if (!directive.templateUrl && directive.controller) {
+ controllerDirectives = controllerDirectives || {};
+ assertNoDuplicate("'" + directiveName + "' controller",
+ controllerDirectives[directiveName], directive, $compileNode);
+ controllerDirectives[directiveName] = directive;
+ }
+
if (directive.terminal) {
nodeLinkFn.terminal = true;
terminalPriority = Math.max(terminalPriority, directive.priority);
@@ -962,7 +962,7 @@ function $CompileProvider($provide) {
origAsyncDirective = directives.shift(),
// The fact that we have to copy and patch the directive seems wrong!
derivedSyncDirective = extend({}, origAsyncDirective, {
- controller: null, templateUrl: null, transclude: null, scope: null
+ templateUrl: null, transclude: null, scope: null
});
$compileNode.html('');
diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js
index 12b51fb4..93fe6ced 100755
--- a/test/ng/compileSpec.js
+++ b/test/ng/compileSpec.js
@@ -2305,6 +2305,70 @@ describe('$compile', function() {
expect(element.text()).toBe('parentTemplateText;childTemplateText;childContentText;babyTemplateText;')
});
});
+
+
+ it('should allow controller usage in pre-link directive functions with templateUrl', function () {
+ module(function () {
+ var Ctrl = function (log) {
+ log('instance');
+ };
+
+ directive('myDirective', function () {
+ return {
+ scope: true,
+ templateUrl: 'hello.html',
+ controller: Ctrl,
+ compile: function () {
+ return {
+ pre: function (scope, template, attr, ctrl) {},
+ post: function () {}
+ };
+ }
+ };
+ });
+ });
+
+ inject(function ($templateCache, $compile, $rootScope, log) {
+ $templateCache.put('hello.html', '<p>Hello</p>');
+
+ element = $compile('<div my-directive></div>')($rootScope);
+ $rootScope.$apply();
+
+ expect(log).toEqual('instance');
+ expect(element.text()).toBe('Hello');
+ });
+ });
+
+
+ it('should allow controller usage in pre-link directive functions with a template', function () {
+ module(function () {
+ var Ctrl = function (log) {
+ log('instance');
+ };
+
+ directive('myDirective', function () {
+ return {
+ scope: true,
+ template: '<p>Hello</p>',
+ controller: Ctrl,
+ compile: function () {
+ return {
+ pre: function (scope, template, attr, ctrl) {},
+ post: function () {}
+ };
+ }
+ };
+ });
+ });
+
+ inject(function ($templateCache, $compile, $rootScope, log) {
+ element = $compile('<div my-directive></div>')($rootScope);
+ $rootScope.$apply();
+
+ expect(log).toEqual('instance');
+ expect(element.text()).toBe('Hello');
+ });
+ });
});