diff options
| author | Misko Hevery | 2011-03-23 09:33:29 -0700 | 
|---|---|---|
| committer | Vojta Jina | 2011-08-02 01:00:03 +0200 | 
| commit | 8f0dcbab804180828d6859b1340c86cf161209fb (patch) | |
| tree | d13d47d47a1889cb7c96a87cecacd2e25307d51c /test/scenario | |
| parent | 1f4b417184ce53af15474de065400f8a686430c5 (diff) | |
| download | angular.js-8f0dcbab804180828d6859b1340c86cf161209fb.tar.bz2 | |
feat(scope): new and improved scope implementation
- Speed improvements (about 4x on flush phase)
- Memory improvements (uses no function closures)
- Break $eval into $apply, $dispatch, $flush
- Introduced $watch and $observe
Breaks angular.equals() use === instead of ==
Breaks angular.scope() does not take parent as first argument
Breaks scope.$watch() takes scope as first argument
Breaks scope.$set(), scope.$get are removed
Breaks scope.$config is removed
Breaks $route.onChange callback has not "this" bounded
Diffstat (limited to 'test/scenario')
| -rw-r--r-- | test/scenario/SpecRunnerSpec.js | 15 | ||||
| -rw-r--r-- | test/scenario/dslSpec.js | 15 | 
2 files changed, 14 insertions, 16 deletions
diff --git a/test/scenario/SpecRunnerSpec.js b/test/scenario/SpecRunnerSpec.js index 0e1ffac1..92f000ba 100644 --- a/test/scenario/SpecRunnerSpec.js +++ b/test/scenario/SpecRunnerSpec.js @@ -31,14 +31,13 @@ describe('angular.scenario.SpecRunner', function() {      $window.setTimeout = function(fn, timeout) {        fn();      }; -    $root = angular.scope({ -      emit: function(eventName) { -        log.push(eventName); -      }, -      on: function(eventName) { -        log.push('Listener Added for ' + eventName); -      } -    }); +    $root = angular.scope(); +    $root.emit = function(eventName) { +      log.push(eventName); +    }; +    $root.on = function(eventName) { +      log.push('Listener Added for ' + eventName); +    };      $root.application = new ApplicationMock($window);      $root.$window = $window;      runner = $root.$new(angular.scenario.SpecRunner); diff --git a/test/scenario/dslSpec.js b/test/scenario/dslSpec.js index a07d411e..5485fe52 100644 --- a/test/scenario/dslSpec.js +++ b/test/scenario/dslSpec.js @@ -10,14 +10,13 @@ describe("angular.scenario.dsl", function() {        document: _jQuery("<div></div>"),        angular: new angular.scenario.testing.MockAngular()      }; -    $root = angular.scope({ -      emit: function(eventName) { -        eventLog.push(eventName); -      }, -      on: function(eventName) { -        eventLog.push('Listener Added for ' + eventName); -      } -    }); +    $root = angular.scope(); +    $root.emit = function(eventName) { +      eventLog.push(eventName); +    }; +    $root.on = function(eventName) { +      eventLog.push('Listener Added for ' + eventName); +    };      $root.futures = [];      $root.futureLog = [];      $root.$window = $window;  | 
