diff options
| author | Igor Minar | 2011-08-14 03:24:09 -0700 | 
|---|---|---|
| committer | Igor Minar | 2011-08-15 12:51:41 -0700 | 
| commit | 793ecb48176ad6d8866ce38f4242971c81ceda31 (patch) | |
| tree | 0f4a6c975bcab004f7878a4765c56c87b3e34c02 /test/jqLiteSpec.js | |
| parent | 1d45e65f4a026eb0461429f2557a5f0400b7f88e (diff) | |
| download | angular.js-793ecb48176ad6d8866ce38f4242971c81ceda31.tar.bz2 | |
refactor(jqLite): remove jqLite show/hide support
it turns out that even with our tricks, jqLite#show is not usable in
practice and definitely not on par with jQuery. so rather than
introducing half-baked apis which introduce issues, I'm removing them.
I also removed show/hide uses from docs, since they are not needed.
Breaks jqLite.hide/jqLite.show which are no longer available.
Diffstat (limited to 'test/jqLiteSpec.js')
| -rw-r--r-- | test/jqLiteSpec.js | 56 | 
1 files changed, 0 insertions, 56 deletions
diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js index 0620fea7..00760a60 100644 --- a/test/jqLiteSpec.js +++ b/test/jqLiteSpec.js @@ -511,62 +511,6 @@ describe('jqLite', function(){    }); -  describe('hide', function() { -    var element; - -    afterEach(function() { -      if (element) dealoc(element); -    }); - -    it('should hide the element', function() { -      element = jqLite('<div></div>'); -      expect(isCssVisible(element)).toBe(true); -      element.hide(); -      expect(isCssVisible(element)).toBe(false); -    }); -  }); - - -  describe('show', function() { -    var element; - -    afterEach(function() { -      if (element) dealoc(element); -      element.remove(); -    }); - - -    it('should show the element ', function() { -      element = jqLite('<div></div>'); -      element[0].style.display = 'none'; -      expect(isCssVisible(element)).toBe(false); -      element.show(); -      expect(isCssVisible(element)).toBe(true); -    }); - - -    it('should show previously hidden element and preserve the display value', function() { -      element = jqLite('<div style="display:inline">xx</div>'); -      jqLite(document.body).append(element); -      element.hide(); -      expect(isCssVisible(element)).toBe(false); -      element.show(); -      expect(element[0].style.display).toBe('inline'); -      expect(isCssVisible(element)).toBe(true); - -      element[0].style.display = 'block'; -      element.hide(); -      expect(isCssVisible(element)).toBe(false); -      element.show(); -      expect(isCssVisible(element)).toBe(true); - -      // this totally doesn't make sense, it should be 'block', but jquery (1.4.2+1.6.2) behaves -      // this way. -      expect(element[0].style.display).toBe('inline'); -    }); -  }); - -    describe('eq', function() {      it('should select the nth element ', function() {        var element = jqLite('<div><span>aa</span></div><div><span>bb</span></div>');  | 
