refactor($compile): move methods of attr object into prototype

We have many instances of this object and we clone them as well (e.g. ng-repeat).
This should save some memory and performance as well.

Double prefixed private properties of attr object:
attr.$element -> attr.$$element
attr.$observers -> attr.$$observers

Update shallowCopy to not copy $$ properties and allow passing optional destination object.

1 files changed, 9 insertions, 0 deletions

diff --git a/test/AngularSpec.js b/test/AngularSpec.js
index da56449a..cf34305a 100644
--- a/test/AngularSpec.js
+++ b/test/AngularSpec.js
@@ -88,6 +88,15 @@ describe('angular', function() {
       expect(copy).toEqual(original);
       expect(copy.key).toBe(original.key);
     });
+
+    it('should not copy $$ properties nor prototype properties', function() {
+      var original = {$$some: true, $$: true};
+      var clone = {};
+
+      expect(shallowCopy(original, clone)).toBe(clone);
+      expect(clone.$$some).toBeUndefined();
+      expect(clone.$$).toBeUndefined();
+    });
   });
 
   describe('elementHTML', function() {