Properly initialize cookie service in order to preserve existing cookies

- previously the poller initialized the cookie cache too late which
  was causing previously existing cookies to be deleted by cookie service
- refactored the poller api so that the addPollFn returns the added fn
- fixed older cookie service tests
- removed "this.$onEval(PRIORITY_LAST, update);" because it is not needed

1 files changed, 4 insertions, 3 deletions

diff --git a/src/services.js b/src/services.js
index ddeebe1f..56637573 100644
--- a/src/services.js
+++ b/src/services.js
@@ -409,16 +409,17 @@ angularService('$cookies', function($browser) {
       rootScope = this,
       lastCookies;
 
-  $browser.addPollFn(function(){
+  //creates a poller fn that copies all cookies from the $browser to service & inits the service
+  $browser.addPollFn(function() {
     var currentCookies = $browser.cookies();
     if (lastCookies != currentCookies) {
       lastCookies = currentCookies;
       copy(currentCookies, cookies);
       rootScope.$eval();
     }
-  });
+  })();
 
-  this.$onEval(PRIORITY_FIRST, update);
+  //at the end of each eval, push cookies
   this.$onEval(PRIORITY_LAST, update);
 
   return cookies;