diff options
| author | Vojta Jina | 2013-02-14 14:39:55 -0800 |
|---|---|---|
| committer | Vojta Jina | 2013-02-14 14:52:46 -0800 |
| commit | 288b69a314e9bd14458b6647532eb62aad5c5cdf (patch) | |
| tree | ab1b1e4eb441b5340780ff44589c3b8186510142 /src/ng/http.js | |
| parent | 2a2123441c2b749b8f316a24c3ca3f77a9132a01 (diff) | |
| download | angular.js-288b69a314e9bd14458b6647532eb62aad5c5cdf.tar.bz2 | |
fix($http): do not encode special characters `@$:,` in params
encodeURIComponent is too aggressive and doesn't follow http://www.ietf.org/rfc/rfc3986.txt
with regards to the character set (pchar) allowed in path segments so we need
this test to make sure that we don't over-encode the params and break stuff
like buzz api which uses @self.
This is has already been fixed in `$resource`. This commit fixes it in a same way
for `$http` as well.
BREAKING CHANGE: $http does follow RFC3986 and does not encode special characters
like `$@,:` in params. If your application needs to encode these characters, encode
them manually, before sending the request.
Diffstat (limited to 'src/ng/http.js')
| -rw-r--r-- | src/ng/http.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/ng/http.js b/src/ng/http.js index 65d2ee5d..4288e7c1 100644 --- a/src/ng/http.js +++ b/src/ng/http.js @@ -818,8 +818,8 @@ function $HttpProvider() { if (isObject(v)) { v = toJson(v); } - parts.push(encodeURIComponent(key) + '=' + - encodeURIComponent(v)); + parts.push(encodeUriQuery(key) + '=' + + encodeUriQuery(v)); }); }); return url + ((url.indexOf('?') == -1) ? '?' : '&') + parts.join('&'); |
