diff options
| author | Xiangru Chen | 2012-07-14 17:40:24 +0800 |
|---|---|---|
| committer | Misko Hevery | 2012-09-06 15:49:49 -0700 |
| commit | fd3071843ca53a34a084f5d495f9f0aea82f2ef5 (patch) | |
| tree | 182ba2c009bb078a7a11f345d6ef7d5f0076fd12 /src/ng/directive/booleanAttrs.js | |
| parent | a631ceb223392244d6241c5bb44712ef802f0c98 (diff) | |
| download | angular.js-fd3071843ca53a34a084f5d495f9f0aea82f2ef5.tar.bz2 | |
fix(ngSrc): don't set src if value is empty string
Current implementation of ngSrc may lead to empty src attribute when page is loading.
For example:
<img ng-src="{{image.url}}">
can be temporarily rendered as
<img src="">
before the image resource is loaded.
Some browser emits a request to the current page when seeing <img src=""> (Firefox13 and IE8 will, Chromium20 won't), which leads to performance problems.
Diffstat (limited to 'src/ng/directive/booleanAttrs.js')
| -rw-r--r-- | src/ng/directive/booleanAttrs.js | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/ng/directive/booleanAttrs.js b/src/ng/directive/booleanAttrs.js index cce10a3b..2cc26ce7 100644 --- a/src/ng/directive/booleanAttrs.js +++ b/src/ng/directive/booleanAttrs.js @@ -302,6 +302,9 @@ forEach(['src', 'href'], function(attrName) { priority: 99, // it needs to run after the attributes are interpolated link: function(scope, element, attr) { attr.$observe(normalized, function(value) { + if (!value) + return; + attr.$set(attrName, value); // on IE, if "ng:src" directive declaration is used and "src" attribute doesn't exist |