style(*): wrap all assignments in if statements

we commonly assign stuff in if statments like this:

if (variable = someFn()) {
  //do something with variable
}

This results in lint and IDE warnings (did you mean ==?).

It is better to be explicit about our intention and wrap the assignement
into parens:

if ((variable = someFn())) {
  //do something with variable
}

Doing so suppresses warnings + is easier to understand the intention.

I verified that the closure compiler strips the extra parens, so there
is no byte overhead for this safety practice.

We should use this style going forward...

1 files changed, 2 insertions, 2 deletions

diff --git a/src/Compiler.js b/src/Compiler.js
index 98e9630c..0001f8af 100644
--- a/src/Compiler.js
+++ b/src/Compiler.js
@@ -229,14 +229,14 @@ Compiler.prototype = {
     template = new Template();
     eachAttribute(element, function(value, name){
       if (!widget) {
-        if (widget = self.widgets('@' + name)) {
+        if ((widget = self.widgets('@' + name))) {
           element.addClass('ng-attr-widget');
           widget = bind(selfApi, widget, value, element);
         }
       }
     });
     if (!widget) {
-      if (widget = self.widgets(elementName)) {
+      if ((widget = self.widgets(elementName))) {
         if (elementNamespace)
           element.addClass('ng-widget');
         widget = bind(selfApi, widget, element);