diff options
| author | Igor Minar | 2011-03-26 16:06:38 -0700 |
|---|---|---|
| committer | Igor Minar | 2011-03-26 23:19:04 -0700 |
| commit | 1e59822df7366094dbf38b0c4ce0cc979258ad19 (patch) | |
| tree | f171a959e390bda54988369eb634dfd5dc73e30a /src/Browser.js | |
| parent | d95a6925cdb5e8009b11fe3ce6dcc8d579bb4234 (diff) | |
| download | angular.js-1e59822df7366094dbf38b0c4ce0cc979258ad19.tar.bz2 | |
remove _null and _undefined
they have no significant effect on minified and gziped size. in fact
they make things worse.
file | before | after removal
----------------------------------------
concat | 325415 | 325297
min | 62070 | 62161
min + gzip | 25187 | 25176
The bottom line is that we are getting 0.05% decrease in size after
gzip without all of the hassle of using underscores everywhere.
Diffstat (limited to 'src/Browser.js')
| -rw-r--r-- | src/Browser.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/Browser.js b/src/Browser.js index e51df16c..55439762 100644 --- a/src/Browser.js +++ b/src/Browser.js @@ -95,7 +95,7 @@ function Browser(window, document, body, XHR, $log) { var script = jqLite('<script>') .attr({type: 'text/javascript', src: url.replace('JSON_CALLBACK', callbackId)}); window[callbackId] = function(data){ - window[callbackId] = _undefined; + window[callbackId] = undefined; script.remove(); completeOutstandingRequest(callback, 200, data); }; @@ -290,7 +290,7 @@ function Browser(window, document, body, XHR, $log) { var cookieLength, cookieArray, cookie, i, keyValue, index; if (name) { - if (value === _undefined) { + if (value === undefined) { rawDocument.cookie = escape(name) + "=;expires=Thu, 01 Jan 1970 00:00:00 GMT"; } else { if (isString(value)) { |