diff options
| author | Misko Hevery | 2011-10-07 11:27:49 -0700 |
|---|---|---|
| committer | Igor Minar | 2011-10-11 11:01:46 -0700 |
| commit | fd822bdaf9d04e522aaa5400b673f333190abe98 (patch) | |
| tree | 451cd26d3f7da862692d6c56e6e8f235824c180a /docs/content/guide/dev_guide.unit-testing.ngdoc | |
| parent | 4f78fd692c0ec51241476e6be9a4df06cd62fdd6 (diff) | |
| download | angular.js-fd822bdaf9d04e522aaa5400b673f333190abe98.tar.bz2 | |
chore(formating): clean code to be function() {
Diffstat (limited to 'docs/content/guide/dev_guide.unit-testing.ngdoc')
| -rw-r--r-- | docs/content/guide/dev_guide.unit-testing.ngdoc | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/docs/content/guide/dev_guide.unit-testing.ngdoc b/docs/content/guide/dev_guide.unit-testing.ngdoc index 459b6b93..978784f9 100644 --- a/docs/content/guide/dev_guide.unit-testing.ngdoc +++ b/docs/content/guide/dev_guide.unit-testing.ngdoc @@ -43,11 +43,11 @@ on a constructor permanently binds the call site to the type. For example lets s trying to instantiate an `XHR` so that we can get some data from the server. <pre> -function MyClass(){ - this.doWork = function(){ +function MyClass() { + this.doWork = function() { var xhr = new XHR(); xhr.open(method, url, true); - xhr.onreadystatechange = function(){...} + xhr.onreadystatechange = function() {...} xhr.send(); } } @@ -61,7 +61,7 @@ patching, that is a bad idea for many reasons, which is outside the scope of thi The class above is hard to test since we have to resort to monkey patching: <pre> var oldXHR = XHR; -XHR = function MockXHR(){}; +XHR = function MockXHR() {}; var myClass = new MyClass(); myClass.doWork(); // assert that MockXHR got called with the right arguments @@ -73,8 +73,8 @@ XHR = oldXHR; // if you forget this bad things will happen Another way to approach the problem is look for the service in a well known location. <pre> -function MyClass(){ - this.doWork = function(){ +function MyClass() { + this.doWork = function() { global.xhr({ method:'...', url:'...', @@ -94,7 +94,7 @@ State & Singletons} The class above is hard to test since we have to change global state: <pre> var oldXHR = glabal.xhr; -glabal.xhr = function mockXHR(){}; +glabal.xhr = function mockXHR() {}; var myClass = new MyClass(); myClass.doWork(); // assert that mockXHR got called with the right arguments @@ -110,7 +110,7 @@ having the tests replace the services as needed. <pre> function MyClass() { var serviceRegistry = ????; - this.doWork = function(){ + this.doWork = function() { var xhr = serviceRegistry.get('xhr'); xhr({ method:'...', @@ -128,7 +128,7 @@ there is only one global variable to be reset). The class above is hard to test since we have to change global state: <pre> var oldServiceLocator = glabal.serviceLocator; -glabal.serviceLocator.set('xhr', function mockXHR(){}); +glabal.serviceLocator.set('xhr', function mockXHR() {}); var myClass = new MyClass(); myClass.doWork(); // assert that mockXHR got called with the right arguments @@ -141,7 +141,7 @@ Lastly the dependency can be passed in. <pre> function MyClass(xhr) { - this.doWork = function(){ + this.doWork = function() { xhr({ method:'...', url:'...', @@ -174,13 +174,13 @@ for your application is mixed in with DOM manipulation, it will be hard to test below: <pre> -function PasswordController(){ +function PasswordController() { // get references to DOM elements var msg = $('.ex1 span'); var input = $('.ex1 input'); var strength; - this.grade = function(){ + this.grade = function() { msg.removeClass(strength); var pwd = input.val(); password.text(pwd); @@ -219,9 +219,9 @@ In angular the controllers are strictly separated from the DOM manipulation logi a much easier testability story as can be seen in this example: <pre> -function PasswordCntrl(){ +function PasswordCntrl() { this.password = ''; - this.grade = function(){ + this.grade = function() { var size = this.password.length; if (size > 8) { this.strength = 'strong'; |
