aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIgor Minar2010-08-13 15:14:41 -0700
committerIgor Minar2010-08-13 15:14:41 -0700
commit7159b30752f63ad8a127101cbc10d7e672ae1620 (patch)
treee49e5a6ef6394ec9453e8f89df41c1939cc4bfe9
parent84b3a1774edb1e12ba0076e32fe8928ba54a48e3 (diff)
downloadangular.js-7159b30752f63ad8a127101cbc10d7e672ae1620.tar.bz2
Serialize only own properties to avoid infinite loops when serializing scopes (this)
-rw-r--r--src/JSON.js2
-rw-r--r--test/JsonTest.js7
2 files changed, 8 insertions, 1 deletions
diff --git a/src/JSON.js b/src/JSON.js
index 340b075a..0d2fbca4 100644
--- a/src/JSON.js
+++ b/src/JSON.js
@@ -74,7 +74,7 @@ function toJsonArray(buf, obj, pretty, stack){
var childPretty = pretty ? pretty + " " : false;
var keys = [];
for(var k in obj) {
- if (k.indexOf('$$') === 0 || obj[k] === undefined)
+ if (!obj.hasOwnProperty(k) || k.indexOf('$$') === 0 || obj[k] === undefined)
continue;
keys.push(k);
}
diff --git a/test/JsonTest.js b/test/JsonTest.js
index 4afb7743..d077c0df 100644
--- a/test/JsonTest.js
+++ b/test/JsonTest.js
@@ -74,6 +74,13 @@ JsonTest.prototype.testItShouldPreventRecursion = function () {
assertEquals('{"a":"b","recursion":RECURSION}', angular.toJson(obj));
};
+JsonTest.prototype.testItShouldSerializeOnlyOwnProperties = function() {
+ var parent = { p: 'p'};
+ var child = { c: 'c'};
+ child.__proto__ = parent;
+ assertEquals('{"c":"c"}', angular.toJson(child));
+}
+
JsonTest.prototype.testItShouldSerializeSameObjectsMultipleTimes = function () {
var obj = {a:'b'};
assertEquals('{"A":{"a":"b"},"B":{"a":"b"}}', angular.toJson({A:obj, B:obj}));