diff options
| author | Tom Dunstan | 2013-08-15 09:33:32 +0930 |
|---|---|---|
| committer | Vojta Jina | 2013-08-15 15:50:34 -0700 |
| commit | 3bc4e7fd20372c0cad8298bff019b32681b16026 (patch) | |
| tree | f3081571722cf22b8bf489bdb46a0f4068b9ea9c | |
| parent | 3a65822023119b71deab5e298c7ef2de204caa13 (diff) | |
| download | angular.js-3bc4e7fd20372c0cad8298bff019b32681b16026.tar.bz2 | |
fix(filter): filter on false properties
Code was evaluating !expression[key] while attempting to
see if the key was present, but this was evaluating to true for
false values as well as missing keys.
Closes #2797.
| -rw-r--r-- | src/ng/filter/filter.js | 2 | ||||
| -rw-r--r-- | test/ng/filter/filterSpec.js | 11 |
2 files changed, 12 insertions, 1 deletions
diff --git a/src/ng/filter/filter.js b/src/ng/filter/filter.js index 5c3c917b..be01b1b3 100644 --- a/src/ng/filter/filter.js +++ b/src/ng/filter/filter.js @@ -183,7 +183,7 @@ function filterFilter() { })(); } else { (function() { - if (!expression[key]) return; + if (typeof(expression[key]) == 'undefined') { return; } var path = key; predicates.push(function(value) { return search(getter(value,path), expression[path]); diff --git a/test/ng/filter/filterSpec.js b/test/ng/filter/filterSpec.js index 4f357371..881cefab 100644 --- a/test/ng/filter/filterSpec.js +++ b/test/ng/filter/filterSpec.js @@ -60,6 +60,17 @@ describe('Filter: filter', function() { expect(filter(items, {first:'misko', last:'hevery'})[0]).toEqual(items[0]); }); + it('should support boolean properties', function() { + var items = [{name: 'tom', current: true}, + {name: 'demi', current: false}, + {name: 'sofia'}]; + + expect(filter(items, {current:true}).length).toBe(1); + expect(filter(items, {current:true})[0].name).toBe('tom'); + expect(filter(items, {current:false}).length).toBe(1); + expect(filter(items, {current:false})[0].name).toBe('demi'); + }); + it('should support negation operator', function() { var items = ['misko', 'adam']; |
