diff options
| author | Vojta Jina | 2011-07-08 12:18:26 +0200 |
|---|---|---|
| committer | Igor Minar | 2011-07-12 23:04:46 -0700 |
| commit | 10da625ed93511dbf5d4e61ca4e42f6f2d478959 (patch) | |
| tree | 754722015f0f677aa36c90dba2dd396430187b2c | |
| parent | 9ee9ca13da3883d06733637f9048a83d94e6f1f8 (diff) | |
| download | angular.js-10da625ed93511dbf5d4e61ca4e42f6f2d478959.tar.bz2 | |
fix:jqLite: Normalize non-existing attributes to undefined as jQuery
jqLite was returning null, but jQuery returns undefined
| -rw-r--r-- | src/jqLite.js | 4 | ||||
| -rw-r--r-- | test/jqLiteSpec.js | 4 |
2 files changed, 7 insertions, 1 deletions
diff --git a/src/jqLite.js b/src/jqLite.js index 5e9d777a..a2dc02cd 100644 --- a/src/jqLite.js +++ b/src/jqLite.js @@ -266,7 +266,9 @@ forEach({ } else if (element.getAttribute) { // the extra argument "2" is to get the right thing for a.href in IE, see jQuery code // some elements (e.g. Document) don't have get attribute, so return undefined - return element.getAttribute(name, 2); + var ret = element.getAttribute(name, 2); + // normalize non-existing attributes to undefined (as jQuery) + return ret === null ? undefined : ret; } }, diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js index fafe7f2a..2c05a7e5 100644 --- a/test/jqLiteSpec.js +++ b/test/jqLiteSpec.js @@ -162,6 +162,10 @@ describe('jqLite', function(){ expect(select.attr('multiple')).toEqual(true); }); + it('should return undefined for non-existing attributes', function() { + var elm = jqLite('<div class="any">a</div>'); + expect(elm.attr('non-existing')).toBeUndefined(); + }); }); |
