diff options
| author | Chirayu Krishnappa | 2014-03-13 17:42:43 -0700 |
|---|---|---|
| committer | Tobias Bosch | 2014-03-20 13:55:12 -0700 |
| commit | 0c930a1a86b3e8c14a1ed87c91f074b434895f93 (patch) | |
| tree | d4cda46d23e8df924be59d661d8c1ef344374202 | |
| parent | 2f61b2f04539df5a6879a7f0c2db3fe80b91c0d8 (diff) | |
| download | angular.js-0c930a1a86b3e8c14a1ed87c91f074b434895f93.tar.bz2 | |
fix(version-info): explicitly specify the remote
`git ls-remote --tags` assumes that you have a remote set up for your
current branch. That isn't the case, at least for me, when I'm working
on local branches. `grunt write` doesn't do the right thing in that
case (`git ls-remote --tags` bails out and the silent: true param makes
this a pain to debug.) Prefer explicit to implicit.
Closes #6678.
| -rw-r--r-- | lib/versions/version-info.js | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/versions/version-info.js b/lib/versions/version-info.js index 2964c4f2..3ee5e261 100644 --- a/lib/versions/version-info.js +++ b/lib/versions/version-info.js @@ -104,7 +104,9 @@ var getPreviousVersions = function() { // always use the remote tags as the local clone might // not contain all commits when cloned with git clone --depth=... // Needed e.g. for Travis - var tagResults = shell.exec('git ls-remote --tags | grep -o -e "v[0-9].*[0-9]$"', {silent: true}); + var repo_url = currentPackage.repository.url; + var tagResults = shell.exec('git ls-remote --tags ' + repo_url + ' | grep -o -e "v[0-9].*[0-9]$"', + {silent: true}); if ( tagResults.code === 0 ) { return _(tagResults.output.trim().split('\n')) .map(function(tag) { @@ -175,6 +177,6 @@ var getSnapshotVersion = function() { exports.currentPackage = currentPackage = getPackage(); +exports.gitRepoInfo = gitRepoInfo = getGitRepoInfo(); exports.previousVersions = previousVersions = getPreviousVersions(); exports.currentVersion = getTaggedVersion() || getSnapshotVersion(); -exports.gitRepoInfo = getGitRepoInfo(); |
