diff options
| author | Daniel Luxemburg | 2014-02-03 20:04:46 -0500 |
|---|---|---|
| committer | Tobias Bosch | 2014-02-04 16:41:25 -0800 |
| commit | dd24c78373b5d24ecb3b9d19e61e1b3b6c74d155 (patch) | |
| tree | 7e0de9522b19e920ab6994da83e2b163c80cf0f3 | |
| parent | 36d37c0e3880c774d20c014ade60d2331beefa15 (diff) | |
| download | angular.js-dd24c78373b5d24ecb3b9d19e61e1b3b6c74d155.tar.bz2 | |
fix(ngMock): return false from mock $interval.cancel() when no argument is supplied
Closes #6103.
Closed #6099.
| -rw-r--r-- | src/ngMock/angular-mocks.js | 1 | ||||
| -rw-r--r-- | test/ngMock/angular-mocksSpec.js | 5 |
2 files changed, 6 insertions, 0 deletions
diff --git a/src/ngMock/angular-mocks.js b/src/ngMock/angular-mocks.js index bb720c1d..a6bcea88 100644 --- a/src/ngMock/angular-mocks.js +++ b/src/ngMock/angular-mocks.js @@ -504,6 +504,7 @@ angular.mock.$IntervalProvider = function() { }; $interval.cancel = function(promise) { + if(!promise) return false; var fnIndex; angular.forEach(repeatFns, function(fn, index) { diff --git a/test/ngMock/angular-mocksSpec.js b/test/ngMock/angular-mocksSpec.js index e5f67a7e..c2b6108d 100644 --- a/test/ngMock/angular-mocksSpec.js +++ b/test/ngMock/angular-mocksSpec.js @@ -509,6 +509,11 @@ describe('ngMock', function() { it('should not throw a runtime exception when given an undefined promise', inject(function($interval) { + var task1 = jasmine.createSpy('task1'), + promise1; + + promise1 = $interval(task1, 1000, 1); + expect($interval.cancel()).toBe(false); })); }); |
