angular.js/test/service/routeSpec.js, branch v1.0.0rc11 chore(module): move files around in preparation for more modules 2012-03-28T18:16:35+00:00 Misko Hevery 2012-03-23T21:03:24+00:00 2430f52bb97fa9d682e5f028c977c5bf94c5ec38 






feat($route): when matching consider trailing slash as optional
2012-03-20T18:07:37+00:00

Igor Minar

2012-03-20T07:38:08+00:00

a4fe51da3ba0dc297ecd389e230d6664f250c9a6

This makes for a much more flexible route matching:

- route /foo matches /foo and redirects /foo/ to /foo
- route /bar/ matches /bar/ and redirects /bar to /bar/

Closes #784





This makes for a much more flexible route matching:

- route /foo matches /foo and redirects /foo/ to /foo
- route /bar/ matches /bar/ and redirects /bar to /bar/

Closes #784







refactor(ng:view) Make $route scope agnostic, add $contentLoaded event
2012-02-29T01:46:58+00:00

Vojta Jina

2012-02-19T20:31:11+00:00

9486590e1be7282bb0e87586a35ca0bee6c64ee0

Problems:

- controller was instantiated immediately on $afterRouteChange (even if no content), that's
different compare to ng:controller, which instantiates controllers after compiling
- route listened on current scope ($afterRouteChange), so if you were listening on $rootScope
($afterRouteChange), you get called first and current.scope === undefined, which is flaky
- route handles scope destroying, but scope is created by ng:view
- route fires after/before route change even if there is no route (when no otherwise specified)

Solution:

- route has no idea about scope, whole scope business moved to ng:view (creating/destroying)
- scope is created (and controller instantiated) AFTER compiling the content
- that means on $afterRouteChange - there is no scope yet (current.scope === undefined)
- added $contentLoaded event fired by ng:view, after linking the content





Problems:

- controller was instantiated immediately on $afterRouteChange (even if no content), that's
different compare to ng:controller, which instantiates controllers after compiling
- route listened on current scope ($afterRouteChange), so if you were listening on $rootScope
($afterRouteChange), you get called first and current.scope === undefined, which is flaky
- route handles scope destroying, but scope is created by ng:view
- route fires after/before route change even if there is no route (when no otherwise specified)

Solution:

- route has no idea about scope, whole scope business moved to ng:view (creating/destroying)
- scope is created (and controller instantiated) AFTER compiling the content
- that means on $afterRouteChange - there is no scope yet (current.scope === undefined)
- added $contentLoaded event fired by ng:view, after linking the content







refactor($route): remove .parent(); ng:view scope creation
2012-02-29T01:46:58+00:00

Misko Hevery

2012-02-16T05:49:07+00:00

e31d1c287d972d633bdaf9c385d3012192f64918












refactor($route): move when/otherwise to provider
2012-02-29T01:46:58+00:00

Misko Hevery

2012-02-15T23:45:07+00:00

f16bd2f747ed94547eabdc4c337775a22a365255












refactor(scope.$watch): rearrange arguments passed into watcher (newValue, oldValue, scope)
2012-01-23T19:11:27+00:00

Vojta Jina

2011-11-30T20:23:58+00:00

0196411dbe179afe24f4faa6d6503ff3f69472da

As scopes are injected into controllers now, you have the reference anyway, so having scope as first argument makes no sense…

Breaks $watcher gets arguments in different order (newValue, oldValue, scope)




As scopes are injected into controllers now, you have the reference anyway, so having scope as first argument makes no sense…

Breaks $watcher gets arguments in different order (newValue, oldValue, scope)






refactor(scope): separate controller from scope
2012-01-23T19:05:36+00:00

Vojta Jina

2011-11-30T05:51:59+00:00

992c790f0786fa45c1cc3710f29bf49c7c322ba7

Controller is standalone object, created using "new" operator, not messed up with scope anymore.
Instead, related scope is injected as $scope.

See design proposal: https://docs.google.com/document/pub?id=1SsgVj17ec6tnZEX3ugsvg0rVVR11wTso5Md-RdEmC0k

Closes #321
Closes #425

Breaks controller methods are not exported to scope automatically
Breaks Scope#$new() does not take controller as argument anymore




Controller is standalone object, created using "new" operator, not messed up with scope anymore.
Instead, related scope is injected as $scope.

See design proposal: https://docs.google.com/document/pub?id=1SsgVj17ec6tnZEX3ugsvg0rVVR11wTso5Md-RdEmC0k

Closes #321
Closes #425

Breaks controller methods are not exported to scope automatically
Breaks Scope#$new() does not take controller as argument anymore






fix(route): $destroy scope after update and reload
2011-12-06T21:35:05+00:00

Vojta Jina

2011-12-01T04:12:42+00:00

b9001e914740ea0e3bba357a33ddaf13610c874f

When we update route (changing only search param, no route reload) and then reload (change to different
route), it did not $destroy last scope.





When we update route (changing only search param, no route reload) and then reload (change to different
route), it did not $destroy last scope.







refactor($service): removed almost all references to scope.$service
2011-11-15T00:39:33+00:00

Misko Hevery

2011-11-03T04:37:06+00:00

16597e8b52bdfe34b2239a5ab86a839fa8e980d6

- still need to remove from factory





- still need to remove from factory







refactor(injector): turn scope into a service
2011-11-15T00:39:31+00:00

Misko Hevery

2011-10-17T23:56:56+00:00

48697a2b86dbb12ea8de64cc5fece7caf68b321e

- turn scope into a $rootScope service.
- injector is now a starting point for creating angular application.
- added inject() method which wraps jasmine its/beforeEach/afterEach,
  and which allows configuration and injection of services.
- refactor tests to use inject() where possible

BREAK:
- removed angular.scope() method





- turn scope into a $rootScope service.
- injector is now a starting point for creating angular application.
- added inject() method which wraps jasmine its/beforeEach/afterEach,
  and which allows configuration and injection of services.
- refactor tests to use inject() where possible

BREAK:
- removed angular.scope() method