angular.js/test/ngRoute/directive, branch g3_v1_2 fix($animate): ensure that animateable directives cancel expired leave animations 2014-02-26T19:53:57+00:00 Matias Niemelä 2014-02-21T08:43:50+00:00 e9881991ca0a5019d3a4215477738ed247898ba0 If enter -> leave -> enter -> leave occurs then the first leave animation will animate alongside the second. This causes the very first DOM node (the view in ngView for example) to animate at the same time as the most recent DOM node which ends up being an undesired effect. This fix takes care of this issue. Closes #5886 
If enter -> leave -> enter -> leave occurs then the first leave animation will
animate alongside the second. This causes the very first DOM node (the view in ngView
for example) to animate at the same time as the most recent DOM node which ends
up being an undesired effect. This fix takes care of this issue.

Closes #5886
perf($animate): use rAF instead of timeouts to issue animation callbacks 2014-02-25T02:23:18+00:00 Matias Niemelä 2014-02-25T00:43:57+00:00 4c4537e65e6cf911c9659b562d89e3330ce3ffae 






style: remove ws and enfore no-trailing-ws jscs rule
2014-02-18T18:44:48+00:00

Igor Minar

2014-02-18T11:04:42+00:00

481508d0e7ae9e4984ea380b9a43e589551c7a5b












fix($animate): ensure $animate doesn't break natural CSS transitions
2014-02-15T00:30:48+00:00

Matias Niemelä

2014-02-14T09:02:46+00:00

4f84f6b3e4210ae1eb14728a46d43dd961700a0c

BREAKING CHANGE: ngClass and {{ class }} will now call the `setClass`
animation callback instead of addClass / removeClass when both a
addClass/removeClass operation is being executed on the element during the animation.

Please include the setClass animation callback as well as addClass and removeClass within
your JS animations to work with ngClass and {{ class }} directives.

Closes #6019





BREAKING CHANGE: ngClass and {{ class }} will now call the `setClass`
animation callback instead of addClass / removeClass when both a
addClass/removeClass operation is being executed on the element during the animation.

Please include the setClass animation callback as well as addClass and removeClass within
your JS animations to work with ngClass and {{ class }} directives.

Closes #6019







fix(mocks): rename mock.animate to ngAnimateMock and ensure it contains all test helper code for ngAnimate
2014-02-06T06:22:14+00:00

Matias Niemelä

2014-01-23T00:28:42+00:00

4224cd5182bc93e4a210f75e0a4e4de7f3c544e8

Closes #5822
Closes #5917





Closes #5822
Closes #5917







fix(mocks): remove usage of $animate.flushNext in favour of queing
2014-02-06T06:21:41+00:00

Matias Niemelä

2014-01-23T00:21:05+00:00

906fdad0f95465842e336e057ea97d0633712189

The flushNext method of testing is difficult and highly coupled with the behavior
of ngAnimate's $animate workflow. It is much better instead to just queue all
$animate animation calls into a queue collection which is available on the $animate
service when mock.animate is included as a module within test code.





The flushNext method of testing is difficult and highly coupled with the behavior
of ngAnimate's $animate workflow. It is much better instead to just queue all
$animate animation calls into a queue collection which is available on the $animate
service when mock.animate is included as a module within test code.







fix(ngRoute): instantiate controller when template is empty
2013-12-28T06:45:46+00:00

Caitlin Potter

2013-12-28T01:25:51+00:00

498365f219f65d6c29bdf2f03610a4d3646009bb

Before this change, $route controllers are not instantiated if the template is falsy, which includes
the empty string. This change tests if the template is not undefined, rather than just falsy, in
order to ensure that templates are instantiated even when the template is empty, which people may
have some reason to do.

This "bug" was reported in http://robb.weblaws.org/2013/06/21/angularjs-vs-emberjs/, as a "gotcha"
for AngularJS / ngRoute.

Closes #5550





Before this change, $route controllers are not instantiated if the template is falsy, which includes
the empty string. This change tests if the template is not undefined, rather than just falsy, in
order to ensure that templates are instantiated even when the template is empty, which people may
have some reason to do.

This "bug" was reported in http://robb.weblaws.org/2013/06/21/angularjs-vs-emberjs/, as a "gotcha"
for AngularJS / ngRoute.

Closes #5550







fix(ngView): Add template to DOM before linking other directives
2013-12-13T01:18:44+00:00

Tobias Bosch

2013-12-11T00:45:54+00:00

f8944efe70b81e02704df9b53ea2546c80c73d3b

The template needs to be added to the DOM before
other directives at the same element as `ngView` are linked.

Related to #5247.





The template needs to be added to the DOM before
other directives at the same element as `ngView` are linked.

Related to #5247.







fix(ngView): Don't throw when the ngView element contains content with directives.
2013-11-22T06:20:11+00:00

Tobias Bosch

2013-11-22T05:54:59+00:00

e6521e7491242504250b57dd0ee66af49e653c33

Fixes #5069





Fixes #5069







fix($compile): ensure CSS classes are added and removed only when necessary
2013-11-22T01:47:44+00:00

Matias Niemelä

2013-11-19T03:13:28+00:00

0cd7e8f22721f62b62440bb059ae764ebbe7b42a

When $compile interpolates a CSS class attribute expression it will
do so by comparing the CSS class value already present on the element.
This may lead to unexpected results when dealing with ngClass values being
added and removed therefore it is best that both compile and ngClass delegate
addClass/removeClass operations to the same block of code.





When $compile interpolates a CSS class attribute expression it will
do so by comparing the CSS class value already present on the element.
This may lead to unexpected results when dealing with ngClass values being
added and removed therefore it is best that both compile and ngClass delegate
addClass/removeClass operations to the same block of code.