angular.js/test/ng, branch v1.0.5 fix($compile): sanitize values bound to a[href] 2013-02-20T08:40:51+00:00 Igor Minar 2013-02-19T17:55:05+00:00 a8cc4497063118c766bdfa9464c9cbfc59413a81 






fix(ngClass): keep track of old ngClass value manually
2013-02-19T04:35:40+00:00

Per Rovegård

2013-02-15T23:32:38+00:00

2aa212b19c71df82287b4b074da3ab14cbf37348

ngClassWatchAction, when called as a $watch function, gets the wrong old
value after it has been invoked previously due to observation of the
interpolated class attribute. As a result it doesn't remove classes
properly. Keeping track of the old value manually seems to fix this.

Closes #1637





ngClassWatchAction, when called as a $watch function, gets the wrong old
value after it has been invoked previously due to observation of the
interpolated class attribute. As a result it doesn't remove classes
properly. Keeping track of the old value manually seems to fix this.

Closes #1637







fix(compile): should not leak memory when there are top level empty text nodes
2013-02-18T13:04:24+00:00

Pete Bacon Darwin

2013-02-18T12:05:16+00:00

1f23cfe9c751f84d9fc996df6d54961b2e46e868

The change to prevent <span> elements being wrapped around empty text nodes caused these empty text nodes to have scopes and controllers attached, through jqLite.data() calls, which led to memory leaks and errors in IE8.
Now we exclude all but document nodes and elements from having jqLite.data() set both in the compiler and in ng-view.

Fixes: #1968 and #1876





The change to prevent <span> elements being wrapped around empty text nodes caused these empty text nodes to have scopes and controllers attached, through jqLite.data() calls, which led to memory leaks and errors in IE8.
Now we exclude all but document nodes and elements from having jqLite.data() set both in the compiler and in ng-view.

Fixes: #1968 and #1876







fix($httpBackend): patch for Firefox bug w/ CORS and response headers
2013-02-15T00:52:02+00:00

Will Moore

2013-01-18T22:09:19+00:00

0fa8e47fb5d2df5aab820691696f19662669eed0

A workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=608735
In FF getAllResponseHeaders() returns null if the request is the result of CORS.

Tried to format the code so that when a FF patch is released and gains enough
traction it can easily be selected and deleted. Heavily inspired by jQuery's
patch for the same bug. This patch falls short of passing through custom headers
but covers all of the "simple response headers" in the spec at
http://www.w3.org/TR/cors/

This commit should get reverted once Firefox 21 gets out.

Closes #1468

Conflicts:
	src/ng/httpBackend.js





A workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=608735
In FF getAllResponseHeaders() returns null if the request is the result of CORS.

Tried to format the code so that when a FF patch is released and gains enough
traction it can easily be selected and deleted. Heavily inspired by jQuery's
patch for the same bug. This patch falls short of passing through custom headers
but covers all of the "simple response headers" in the spec at
http://www.w3.org/TR/cors/

This commit should get reverted once Firefox 21 gets out.

Closes #1468

Conflicts:
	src/ng/httpBackend.js







fix(a): workaround IE bug affecting mailto urls
2013-02-15T00:43:28+00:00

Igor Minar

2013-02-14T23:13:50+00:00

8043784fd73a4768f4e904fd4121b21cd1fb49b4

Apparently there is a really weird bug in IE6-8 that causes anchor textContent
to be reset with href content when both contain @ symbol.

Inserting a bogus comment node into all anchor elements in IE works around this
browser bug.

I'm fixing the issue via directive because that way we'll fix it for jQuery as
well.

I fixed an e2e test too because it was incorrect.

Closes #1949





Apparently there is a really weird bug in IE6-8 that causes anchor textContent
to be reset with href content when both contain @ symbol.

Inserting a bogus comment node into all anchor elements in IE works around this
browser bug.

I'm fixing the issue via directive because that way we'll fix it for jQuery as
well.

I fixed an e2e test too because it was incorrect.

Closes #1949







fix($rootScope): minor typo fixes
2013-02-14T22:43:32+00:00

Daniel Luz

2012-11-04T21:26:58+00:00

d7e9ae121531f8ad38efaa9c7a20f4b9d70ce15b












fix(numberFilter): fix formatting when "0" passed as fractionSize
2013-02-14T21:46:07+00:00

Kury Kruitbosch

2013-02-11T21:21:15+00:00

75545d4d1c59192d781bb23d8bd2f72c9be37d38

When checking to add decimal and trialing 0s number filter used to check
trueness of fractionSize. "0" evaluating to true causes "123" to return "123."





When checking to add decimal and trialing 0s number filter used to check
trueness of fractionSize. "0" evaluating to true causes "123" to return "123."







fix($compile): rename $compileNote to compileNode
2013-02-07T10:49:18+00:00

Enrique Paredes

2013-02-04T19:38:52+00:00

934204ec18898602dda329e5fd5d43a25c4bad14

Directives was observing different instances of Attributes than the one
that interpolation was registered with because we failed to realize
that the compile node and link node were the same (one of them
was a wrapper rather than raw node)

Closes #1941





Directives was observing different instances of Attributes than the one
that interpolation was registered with because we failed to realize
that the compile node and link node were the same (one of them
was a wrapper rather than raw node)

Closes #1941







fix($cookies): set cookies on Safari&IE when base[href] is undefined
2013-02-07T10:36:52+00:00

Fredrik Bonander

2013-02-06T09:30:40+00:00

7cb8f8fb4498aa5d8b04310cd4580997e65a7e86

Safari and IE don't like being told to store cookies with path set to
undefined. This change ensures that if base[href] (from which cookie path
is derived) is undefined then the cookie path defaults to ''.

The test verifies that the cookie is set instead of checking that cookie has correct path,
this is due to that cookie meta information is not avabile once the cookie is set.

Closes #1190, #1191





Safari and IE don't like being told to store cookies with path set to
undefined. This change ensures that if base[href] (from which cookie path
is derived) is undefined then the cookie path defaults to ''.

The test verifies that the cookie is set instead of checking that cookie has correct path,
this is due to that cookie meta information is not avabile once the cookie is set.

Closes #1190, #1191







fix(date):  invert timezone sign and always display sign
2013-02-07T09:47:19+00:00

Philip Roberts

2013-01-30T09:50:34+00:00

8d34bf2feaa303ef286e3309ad766ff7d15f8b11

This commit fixes #1261 and #1532. This covers
two separate issues:

- Positive timezones were being formatted without
a leading `+` resulting in a formatting string
like: "HH:MM:ssZ" giving "12:13:141000" instead
of "12:13:14+1000". Fixed by checking if timezone
is > 0 and adding a leading "+".

- Timezone output signs were inverted.
mock.TzDate expects the timezone _offset_ as it's
first argument, _not_ the timezone. This means
that a mock.TzDate with a positive offset should
result in a date string with a negative timezone,
and vice-versa.

Closes #1261, #1532





This commit fixes #1261 and #1532. This covers
two separate issues:

- Positive timezones were being formatted without
a leading `+` resulting in a formatting string
like: "HH:MM:ssZ" giving "12:13:141000" instead
of "12:13:14+1000". Fixed by checking if timezone
is > 0 and adding a leading "+".

- Timezone output signs were inverted.
mock.TzDate expects the timezone _offset_ as it's
first argument, _not_ the timezone. This means
that a mock.TzDate with a positive offset should
result in a date string with a negative timezone,
and vice-versa.

Closes #1261, #1532