angular.js/src/ng/directive, branch v1.0.0rc4 fix(docs): remove ngModelInstant from all examples 2012-04-04T22:56:15+00:00 Igor Minar 2012-04-04T22:56:12+00:00 fdf17d729fa7651e88dc5f27c40b8de875a34a55 just fixing leftover code after the removal of ngModelInstant 
just fixing leftover code after the removal of ngModelInstant
chore(directive): correct file names for booleanAttrs 2012-04-04T21:58:27+00:00 Vojta Jina 2012-04-04T00:26:09+00:00 02cf958a076b140690ab9ea4ed00c490f52cbf91 






fix(booleanAttrs): convert to boolean
2012-04-04T15:26:28+00:00

Vojta Jina

2012-04-04T15:12:39+00:00

dcb8e0767fbf0a7a55f3b0045fd01b2532ea5441

jQuery's attr() does not handle 0 as false, when it comes to boolean attrs.




jQuery's attr() does not handle 0 as false, when it comes to boolean attrs.






fix(form): preperly clean up when invalid widget is removed
2012-04-04T06:28:05+00:00

Misko Hevery

2012-04-04T05:05:13+00:00

21b77ad5c231ab0e05eb89f22005f7ed8d40a6c1

Removing invalid widget sometimes resulted in improper cleanup of the form state.




Removing invalid widget sometimes resulted in improper cleanup of the form state.






fix(ng-href): copy even if no binding
2012-04-03T23:02:20+00:00

Misko Hevery

2012-04-03T22:03:27+00:00

2f5dba488e855bcdbb9304aa809efcb9de7b43e9

Closes# 850

fixed an issue where ng-href would not copy its content into href if it did not contain binding.





Closes# 850

fixed an issue where ng-href would not copy its content into href if it did not contain binding.







refactor(ngView): remove extra $watch, refactor one ugly test
2012-04-03T17:10:44+00:00

Vojta Jina

2012-03-30T22:03:20+00:00

15c1fe392942b70e456f10afbdfd9c3329249a43












feat(ngInclude): allow ngInclude on css class
2012-04-03T17:10:44+00:00

Vojta Jina

2012-03-30T20:55:33+00:00

428f2b563663315df4f235ca19cef4bdcf82e2ab

And make it terminal so that it does not compile its content, which would cause leaks.





And make it terminal so that it does not compile its content, which would cause leaks.







fix(ngInclude): fire $includeContentLoaded on proper (child) scope
2012-04-03T17:10:44+00:00

Vojta Jina

2012-03-30T20:54:43+00:00

199ac269869a57bb63d60c9b3f510d546bf0c9b2












refactor(ngInclude): remove scope attribute
2012-04-03T17:10:44+00:00

Vojta Jina

2012-03-30T20:40:19+00:00

5f70d615a5f7e102424c6adc15d7a6f697870b6e

The purpose of allowing the scope to be specified was to enable the $route service to work
together with ngInclude. However the functionality of creating scopes was in the recent past
moved from the $route service to the ngView directive, so currently there is no valid use case
for specifying the scope for ngInclude. In fact, allowing the scope to be defined can under
certain circumstances lead to memory leaks.

Breaks ngInclude does not have scope attribute anymore.





The purpose of allowing the scope to be specified was to enable the $route service to work
together with ngInclude. However the functionality of creating scopes was in the recent past
moved from the $route service to the ngView directive, so currently there is no valid use case
for specifying the scope for ngInclude. In fact, allowing the scope to be defined can under
certain circumstances lead to memory leaks.

Breaks ngInclude does not have scope attribute anymore.







feat(ngModel): update model on each key stroke (revert ngModelInstant)
2012-04-03T17:10:44+00:00

Vojta Jina

2012-03-30T19:07:19+00:00

06d0955074f79de553cc34fbf945045dc458e064

It turns out that listening only on "blur" event is not sufficient in many scenarios,
especially when you use form validation you always had to use ngModelnstant
e.g. if you want to disable a button based on valid/invalid form.

The feedback we got from our apps as well as external apps is that the
ngModelInstant should be the default.

In the future we might provide alternative ways of suppressing updates
on each key stroke, but it's not going to be the default behavior.

Apps already using the ngModelInstant can safely remove it from their
templates. Input fields without ngModelInstant directive will start propagating
the input changes into the model on each key stroke.





It turns out that listening only on "blur" event is not sufficient in many scenarios,
especially when you use form validation you always had to use ngModelnstant
e.g. if you want to disable a button based on valid/invalid form.

The feedback we got from our apps as well as external apps is that the
ngModelInstant should be the default.

In the future we might provide alternative ways of suppressing updates
on each key stroke, but it's not going to be the default behavior.

Apps already using the ngModelInstant can safely remove it from their
templates. Input fields without ngModelInstant directive will start propagating
the input changes into the model on each key stroke.