angular.js, branch v1.0.x refactor(externs): move Closure Externs back to Closure code repository 2014-01-22T19:39:09+00:00 Martin Probst 2014-01-21T10:18:54+00:00 00b44d8e12de2c928c5c9c7c3b46e9e41a1d43ef While Closure Compiler generally recommends to maintain the externs for projects together with their source, this has not worked well for AngularJS: - Changes to externs must be tested; they can break clients. AngularJS has no testing infrastructure for this. - Changes mostly come from users inside of Google and are much more easily submitted together with the code using them within Google's repository. This change deletes the externs here and adds a README.closure.md to document the change. They will be added back to Closure Compiler in a separate submit. Closes #5907 
While Closure Compiler generally recommends to maintain the externs for
projects together with their source, this has not worked well for
AngularJS:
- Changes to externs must be tested; they can break clients. AngularJS
  has no testing infrastructure for this.
- Changes mostly come from users inside of Google and are much more
  easily submitted together with the code using them within Google's
  repository.

This change deletes the externs here and adds a README.closure.md to
document the change. They will be added back to Closure Compiler in a
separate submit.

Closes #5907
test(compileSpec): fix broken build on FF 2014-01-22T19:19:31+00:00 Igor Minar 2013-12-31T09:36:01+00:00 ca865d29a3d4f21601222e43ee49abad5d38ce93 FF 26.0 now throws: "TypeError: NodeList doesn't have an indexed property setter." when we try to assign to `childNodes[1]`, since this test still works properly on Chrome and the issue being tested is not a cross-browser issues, I'm just making the patchability check more robust instead of trying to figure out how to make this test fully pass on FF. 
FF 26.0 now throws:

"TypeError: NodeList doesn't have an indexed property setter."

when we try to assign to `childNodes[1]`, since this test still works properly
on Chrome and the issue being tested is not a cross-browser issues, I'm
just making the patchability check more robust instead of trying to figure
out how to make this test fully pass on FF.
feat(Angular.js): add externs file for Closure Compiler 2013-10-30T21:59:33+00:00 Martin Probst 2013-10-30T21:56:55+00:00 3ccec13aa702d9a7f75316df0c70873d72148b24 This adds an (incomplete) externs file for use with the Closure Compiler. Users can pass this as -extern to the compiler pass to get type checking and protect their AngularJS use against property renaming in advanced compilation mode. 
This adds an (incomplete) externs file for use with the Closure Compiler. Users
can pass this as -extern to the compiler pass to get type checking and protect
their AngularJS use against property renaming in advanced compilation mode.
revert(validate-commit-msg): fix incorrect comment 2013-10-21T15:27:04+00:00 Daniel Lamb 2013-09-10T15:59:42+00:00 43d49013d103b3e64aeb2b40fa69b182a8128f6d Revert d5b62465f06b652b227b73cd15c298832f1f7070 since it was not valid. Closes #3952 
Revert d5b62465f06b652b227b73cd15c298832f1f7070 since it was not valid.

Closes #3952
docs(guide/controller): improve guidance and examples 2013-10-11T11:59:39+00:00 Pete Bacon Darwin 2013-10-11T11:59:39+00:00 116fac05628807acec6baf331a31b58f26f774a7 Remove mention of global controller functions Convert larger examples to runnable demos Remove mention of pre-1.0 controllers, in particular discussion of controller inheritance. TODO: Probably could do with updating to explain the "controller as" syntax at some point. Closes: #4373 
Remove mention of global controller functions
Convert larger examples to runnable demos
Remove mention of pre-1.0 controllers, in particular discussion of
controller inheritance.

TODO: Probably could do with updating to explain the "controller as" syntax
at some point.

Closes: #4373
docs(guide/controller): use `.controller` syntax 2013-10-11T11:58:22+00:00 Felix 2013-10-10T21:49:55+00:00 c3024254b6535486097648503e2ddae5562b6ddc Use the recommended `module.controller` syntax rather than global functions to define controllers in the examples. 
Use the recommended `module.controller` syntax rather than global
functions to define controllers in the examples.
docs($provide): improve docs and examples further 2013-10-10T17:22:52+00:00 Pete Bacon Darwin 2013-10-10T15:46:59+00:00 770353df1956ab45bdbe45a4d5040caa40bf880f Improve the "tracking" service example by adding a configuration option. Get better formatting of the generated code samples using <pre> tags. Move the detailed explanations into each function's documentation block. Improve the overview and list the constituent functions by significance. Closes #4302 
Improve the "tracking" service example by adding a configuration option.
Get better formatting of the generated code samples using <pre> tags.
Move the detailed explanations into each function's documentation block.
Improve the overview and list the constituent functions by significance.

Closes #4302
docs($provide): improve examples and explanations 2013-10-10T17:22:51+00:00 Tim Ruffles 2013-10-06T22:01:03+00:00 85b7d24357a59876810d8b2494bd2bfbb920a5da $provide's example seems awkward. Replace with more real-world example, using an injected service, where the service defined has a good reason to be a singleton. There's quite a lot of confusion around $provide: http://stackoverflow.com/search?q=angularjs+service+vs+factory Tests for example at: http://jsbin.com/EMabAv/1/edit?js,output 
$provide's example seems awkward. Replace with more real-world example,
using an injected service, where the service defined has a good reason to
be a singleton.

There's quite a lot of confusion around $provide:
http://stackoverflow.com/search?q=angularjs+service+vs+factory
Tests for example at: http://jsbin.com/EMabAv/1/edit?js,output
docs(tutorial/step11): correct Jasmine Matcher link 2013-10-09T10:30:47+00:00 Marko Bonaci 2013-10-08T19:10:42+00:00 8469779a8e18ebf8ff90072872735b1730fdcc70 Link http://pivotal.github.com/jasmine/jsdoc/symbols/jasmine.Matchers.html is no longer valid. Closes #4329 
Link http://pivotal.github.com/jasmine/jsdoc/symbols/jasmine.Matchers.html
is no longer valid.

Closes #4329
docs(ngValue): add docs for ngValue directive 2013-10-07T13:42:54+00:00 Brian Ford 2013-10-03T20:28:44+00:00 3374e35953f41fb255fff276e43afd2fc997f1d7 Closes #4267 
Closes #4267