From 3c522fc313f76dfbb7d1e87703965780245a432c Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Sat, 29 Apr 2017 23:32:17 +0200 Subject: DBShell::Client::Postgres: Convert port to string Turns out the port actually did need to be a string, contrary to what I had assumed in e89275bc787ae17bc698ac8cdb8cdaf5ebeb7852. I ended up with this error when passing a specific port in a real test: $ bake dbshell rake aborted! TypeError: no implicit conversion of Fixnum into String .../lib/dbshell/client/postgres.rb:8:in `exec' .../lib/dbshell/client/postgres.rb:8:in `runshell' .../lib/dbshell/client/database.rb:24:in `runshell' .../lib/dbshell/rails/tasks/dbshell.rake:6:in `block in ' .../versions/2.3.3/bin/bundle:22:in `load' .../versions/2.3.3/bin/bundle:22:in `
' Tasks: TOP => dbshell --- lib/dbshell/client/postgres.rb | 2 +- spec/dbshell/client/postgres_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dbshell/client/postgres.rb b/lib/dbshell/client/postgres.rb index 0e33843..78b82d7 100644 --- a/lib/dbshell/client/postgres.rb +++ b/lib/dbshell/client/postgres.rb @@ -19,7 +19,7 @@ module DBShell args.push('-U', user) if user args.push('-h', host) if host - args.push('-p', port) if port + args.push('-p', port.to_s) if port args.push(db_name) end end diff --git a/spec/dbshell/client/postgres_spec.rb b/spec/dbshell/client/postgres_spec.rb index c9cb2c7..85223a7 100644 --- a/spec/dbshell/client/postgres_spec.rb +++ b/spec/dbshell/client/postgres_spec.rb @@ -18,7 +18,7 @@ describe DBShell::Client::Postgres do '-h', 'mailmarehost', '-p', - 6027, + '6027', 'dbname' ]) end -- cgit v1.2.3