dbshell-rails/lib, branch v0.0.2

Increase version v0.0.1 -> v0.0.2

2017-05-09T18:50:07+00:00

version.rb: Use single quotes

2017-05-09T18:49:30+00:00

Match the style in the rest of the project.

rails.rb: Check that `Rake` is loaded before loading Rake task

2017-05-09T18:30:02+00:00

Was getting an exception when trying to start the development server on
a Rails 5.0.1 app:

    $ bundle exec rails s
    dbshell-rails/lib/dbshell/rails/tasks/dbshell.rake:5:in `': undefined method `desc' for main:Object (NoMethodError)
    	from .../ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/dependencies.rb:287:in `load'
    	from .../ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/dependencies.rb:287:in `block in load'
    	from .../ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/dependencies.rb:259:in `load_dependency'
    	from .../ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/dependencies.rb:287:in `load'
    	from dbshell-rails/lib/dbshell/rails.rb:3:in `'
    	from .../ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/runtime.rb:105:in `require'
    	from .../ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/runtime.rb:105:in `rescue in block in require'
    	from .../ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/runtime.rb:82:in `block in require'
    	from .../ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/runtime.rb:75:in `each'
    	from .../ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/runtime.rb:75:in `require'
    	from .../ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler.rb:107:in `require'
    	from rails-app/config/application.rb:7:in `'
    	from .../ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:88:in `require'
    	from .../ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:88:in `block in server'
    	from .../ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:85:in `tap'
    	from .../ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:85:in `server'
    	from .../ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:49:in `run_command!'
    	from .../ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands.rb:18:in `'
    	from rails-app/bin/rails:9:in `require'
    	from rails-app/bin/rails:9:in `'
    	from .../ruby/gems/2.3.0/gems/spring-2.0.1/lib/spring/client/rails.rb:28:in `load'
    	from .../ruby/gems/2.3.0/gems/spring-2.0.1/lib/spring/client/rails.rb:28:in `call'
    	from .../ruby/gems/2.3.0/gems/spring-2.0.1/lib/spring/client/command.rb:7:in `call'
    	from .../ruby/gems/2.3.0/gems/spring-2.0.1/lib/spring/client.rb:30:in `run'
    	from .../ruby/gems/2.3.0/gems/spring-2.0.1/bin/spring:49:in `'
    	from .../ruby/gems/2.3.0/gems/spring-2.0.1/lib/spring/binstub.rb:31:in `load'
    	from .../ruby/gems/2.3.0/gems/spring-2.0.1/lib/spring/binstub.rb:31:in `'
    	from rails-app/bin/spring:15:in `require'
    	from rails-app/bin/spring:15:in `'
    	from bin/rails:3:in `load'
    	from bin/rails:3:in `'

Looks like Rails is trying to load the task without Rake, and the
interpreter doesn't know what to do with the Rake methods.

Follow the pattern in
https://github.com/paulelliott/fabrication/blob/b470cd817e1973c14e3253cd76606cf934942ca1/lib/fabrication.rb
and guard the load with a check for whether `Rake` is defined.

This makes the server start up and work as expected again.

rails.rb: Simplify `load` call to include Rake task

2017-05-01T02:08:58+00:00

Thanks to the Patterns guide on rubygems.org, I now see that we don't
have to use `__FILE__` at all. Cool!

See:
http://guides.rubygems.org/patterns/#requiring-files-relative-to-each-other

rails.rb: Change to single-quotes

2017-05-01T02:05:32+00:00

Follow this package's convention.

dbshell.rake: Add a short description to our task

2017-05-01T00:30:55+00:00

This has the additional benefit of making it appear in the `rake -T`
output.

dbshell.rake: Add alias to `rake db:shell`

2017-04-29T21:43:01+00:00

Provide two ways of accessing the task. One saves a character (":") and
is reminiscent of the Django command that this project is inspired by.
The other is more Rails-like and is consistent with the other
`db:`-prefixed Rails Rake tasks.

DBShell::Client::Postgres: Convert port to string

2017-04-29T21:32:17+00:00

Turns out the port actually did need to be a string, contrary to what I
had assumed in e89275bc787ae17bc698ac8cdb8cdaf5ebeb7852. I ended up with
this error when passing a specific port in a real test:

    $ bake dbshell
    rake aborted!
    TypeError: no implicit conversion of Fixnum into String
    .../lib/dbshell/client/postgres.rb:8:in `exec'
    .../lib/dbshell/client/postgres.rb:8:in `runshell'
    .../lib/dbshell/client/database.rb:24:in `runshell'
    .../lib/dbshell/rails/tasks/dbshell.rake:6:in `block in '
    .../versions/2.3.3/bin/bundle:22:in `load'
    .../versions/2.3.3/bin/bundle:22:in `'
    Tasks: TOP => dbshell

DBShell::Client::Database: Add support for the 'postgis' adapter

2017-04-29T21:26:59+00:00

PostGIS is, for our purposes, no different from Postgres. Both should
launch `psql`.

rails.rb: Simplify the Rake task loader call

2017-04-29T21:15:00+00:00

Since we only have a single *.rake file, we can get away with making
this less general. Doing so condenses what was there previously into a
single line and is arguably more explicit.