dbshell-rails, branch add-support-for-shell-aliased-database-commands

Try to add support for shell aliases through Ruby's `Kernel.exec`

2017-04-29T22:23:22+00:00

Work in progress.

Ruby's `system` and `exec` don't load shell aliases, so the executables
defined in `EXECUTABLE_NAME` will always be the ones used to launch
database shells.

The trouble is, users might have installed the command with a different
name (as in "mysql5"), or they might not have the command on their path
(as in my case when using Postgres.app).

Apparently you can use an interactive or login shell to get aliases
(using the `-l` or `-i` flags, which do slightly different things,
sourcing .profile and .bashrc separately). Here's what I was following:

http://stackoverflow.com/questions/12060863/python-subprocess-call-a-bash-alias/25099813#25099813

Unfortunately I haven't been able to get it to work. Dropping this for
now.

dbshell.rake: Add a short description to our task

2017-04-29T21:47:42+00:00

This has the additional benefit of making it appear in the `rake -T`
output.

dbshell.rake: Add alias to `rake db:shell`

2017-04-29T21:43:01+00:00

Provide two ways of accessing the task. One saves a character (":") and
is reminiscent of the Django command that this project is inspired by.
The other is more Rails-like and is consistent with the other
`db:`-prefixed Rails Rake tasks.

DBShell::Client::Postgres: Convert port to string

2017-04-29T21:32:17+00:00

Turns out the port actually did need to be a string, contrary to what I
had assumed in e89275bc787ae17bc698ac8cdb8cdaf5ebeb7852. I ended up with
this error when passing a specific port in a real test:

    $ bake dbshell
    rake aborted!
    TypeError: no implicit conversion of Fixnum into String
    .../lib/dbshell/client/postgres.rb:8:in `exec'
    .../lib/dbshell/client/postgres.rb:8:in `runshell'
    .../lib/dbshell/client/database.rb:24:in `runshell'
    .../lib/dbshell/rails/tasks/dbshell.rake:6:in `block in '
    .../versions/2.3.3/bin/bundle:22:in `load'
    .../versions/2.3.3/bin/bundle:22:in `'
    Tasks: TOP => dbshell

DBShell::Client::Database: Add support for the 'postgis' adapter

2017-04-29T21:26:59+00:00

PostGIS is, for our purposes, no different from Postgres. Both should
launch `psql`.

rails.rb: Simplify the Rake task loader call

2017-04-29T21:15:00+00:00

Since we only have a single *.rake file, we can get away with making
this less general. Doing so condenses what was there previously into a
single line and is arguably more explicit.

rails.rb: Move Rake task loader outside of the module context

2017-04-29T21:10:33+00:00

I don't think the load call really needs to be inside the module, as
evidenced by
https://github.com/paulelliott/fabrication/blob/b470cd817e1973c14e3253cd76606cf934942ca1/lib/fabrication.rb

Integrate MySQL support

2017-04-29T20:58:11+00:00

* Create a `.runshell()` method in `DBShell::Client::MySQL`
* Delegate to that class & method from `DBShell::Client::Database`

Rename `InvalidDatabaseAdapter` to `UnsupportedDatabaseAdapter`

2017-04-29T20:54:27+00:00

Tried this out with MySQL, and got this error since I haven't integrated
it yet. It struck me that "Invalid" doesn't make any sense. Really it's
something that is possible to do but that our gem doesn't support, so we
should be clearer about that fact.

Add `DBShell::Client::MySQL`

2017-04-29T20:49:10+00:00

For now only includes a `.build_command()` method.

Inspired again by:
https://github.com/django/django/blob/66150f7cf61bc09547fa98586790df596eff6d77/django/db/backends/mysql/client.py

although in our case we haven't handled some of the more exotic options.
Eventually we'll probably have to do that.