From b2768485750f267cd9ad93a161ee963a6102d402 Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Sun, 9 Jun 2019 21:49:09 +0200 Subject: code-review-start: Only insert merge_bases row if argument was passed Don't create a `merge_bases` entry in the database if no merge base argument was passed to the script. The `get_merge_base` function in `code-review-database` will default to `origin/master` or `master` when no row is found in the database. Rely on those defaults instead of always inserting a row. --- code-review-start | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/code-review-start b/code-review-start index 005d612..a411659 100755 --- a/code-review-start +++ b/code-review-start @@ -13,9 +13,7 @@ source "$SCRIPT/code-review-database" create_database_if_not_exists -merge_base='origin/master' if [ $# -eq 1 ]; then merge_base="$1" + create_merge_base_from_current "$merge_base" fi - -create_merge_base_from_current "$merge_base" -- cgit v1.2.3