<feed xmlns='http://www.w3.org/2005/Atom'>
<title>code-review/code-review-start, branch master</title>
<subtitle>Tools to facilitate code review on the command line</subtitle>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/'/>
<entry>
<title>Add license (GNU GPLv3+)</title>
<updated>2019-06-10T10:48:33+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-10T10:48:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=3bfeca8f6735e9f614f898af56da29775c47d337'/>
<id>3bfeca8f6735e9f614f898af56da29775c47d337</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-start: Only insert merge_bases row if argument was passed</title>
<updated>2019-06-09T19:49:09+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-09T19:49:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=b2768485750f267cd9ad93a161ee963a6102d402'/>
<id>b2768485750f267cd9ad93a161ee963a6102d402</id>
<content type='text'>
Don't create a `merge_bases` entry in the database if no merge base
argument was passed to the script. The `get_merge_base` function in
`code-review-database` will default to `origin/master` or `master` when
no row is found in the database. Rely on those defaults instead of
always inserting a row.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Don't create a `merge_bases` entry in the database if no merge base
argument was passed to the script. The `get_merge_base` function in
`code-review-database` will default to `origin/master` or `master` when
no row is found in the database. Rely on those defaults instead of
always inserting a row.
</pre>
</div>
</content>
</entry>
<entry>
<title>Move database functions from code-review-start to code-review-database</title>
<updated>2019-06-09T19:47:49+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-09T19:43:48+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=df93125733ef95038e9281f605e117ec805218f6'/>
<id>df93125733ef95038e9281f605e117ec805218f6</id>
<content type='text'>
Put these functions in a function-only file that can be sourced by other
scripts that need database access.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Put these functions in a function-only file that can be sourced by other
scripts that need database access.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-start: Add `get_merge_base` function</title>
<updated>2019-06-09T19:36:26+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-09T19:31:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=3ff388797bc3abe7b9996877db4f2fcd860f01f0'/>
<id>3ff388797bc3abe7b9996877db4f2fcd860f01f0</id>
<content type='text'>
Function to get the merge base for the current branch. If none exists in
the database, default to `origin/master` if there's an `origin` remote,
or `master` if not.

Thanks to Serpiton
(https://codereview.stackexchange.com/users/61525/serpiton) on Stack
Overflow for describing how to get a default value using the `MAX()`
function:
https://codereview.stackexchange.com/questions/74192/select-first-value-if-exists-otherwise-select-default-value/74252#74252

Thanks to 'tig' (https://stackoverflow.com/users/96823/tig) on Stack
Overflow for the command to check if a given Git remote exists:
https://stackoverflow.com/questions/12170459/check-if-git-remote-exists-before-first-push/26843249#26843249
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Function to get the merge base for the current branch. If none exists in
the database, default to `origin/master` if there's an `origin` remote,
or `master` if not.

Thanks to Serpiton
(https://codereview.stackexchange.com/users/61525/serpiton) on Stack
Overflow for describing how to get a default value using the `MAX()`
function:
https://codereview.stackexchange.com/questions/74192/select-first-value-if-exists-otherwise-select-default-value/74252#74252

Thanks to 'tig' (https://stackoverflow.com/users/96823/tig) on Stack
Overflow for the command to check if a given Git remote exists:
https://stackoverflow.com/questions/12170459/check-if-git-remote-exists-before-first-push/26843249#26843249
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-start: Add TODO for upsert</title>
<updated>2019-06-05T21:05:54+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-05T21:05:44+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=ccc806cac2e12d4f6c6fbc92e2fd5aef6db79252'/>
<id>ccc806cac2e12d4f6c6fbc92e2fd5aef6db79252</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add draft of 'code-review-start'</title>
<updated>2019-06-05T21:02:07+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-05T20:57:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=c04c1454794b455564dfd8bbf73d8c0c40baa5bd'/>
<id>c04c1454794b455564dfd8bbf73d8c0c40baa5bd</id>
<content type='text'>
This command will store the desired merge base for the current branch,
defaulting to "origin/master". In so doing, subsequent `code-review`
subcommands will have access to this and be able to default to a merge
base branch instead of:

* Having users specify one manually at the command line for each
  `code-review` subcommand
* Having a default merge base branch that's not desired by users

I figure I can hopefully get away with not sanitizing SQL input because
I don't think you can use apostrophes in Git branch names. Otherwise
I'll probably have to port this to another language with a SQLite
library, as it doesn't seem possible to easily sanitize inputs in Bash.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This command will store the desired merge base for the current branch,
defaulting to "origin/master". In so doing, subsequent `code-review`
subcommands will have access to this and be able to default to a merge
base branch instead of:

* Having users specify one manually at the command line for each
  `code-review` subcommand
* Having a default merge base branch that's not desired by users

I figure I can hopefully get away with not sanitizing SQL input because
I don't think you can use apostrophes in Git branch names. Otherwise
I'll probably have to port this to another language with a SQLite
library, as it doesn't seem possible to easily sanitize inputs in Bash.
</pre>
</div>
</content>
</entry>
</feed>
