<feed xmlns='http://www.w3.org/2005/Atom'>
<title>code-review/code-review-difftool, branch master</title>
<subtitle>Tools to facilitate code review on the command line</subtitle>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/'/>
<entry>
<title>Update copyright years on recently changed files</title>
<updated>2023-11-24T20:13:22+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T20:13:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=095286de0e4df86706a807d3898cded4adeeb5d5'/>
<id>095286de0e4df86706a807d3898cded4adeeb5d5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-difftool: Focus new changes buffer instead of old version</title>
<updated>2023-11-24T19:46:20+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T19:46:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=1b46638e39f34ca3cfffdde235db69cd8150d284'/>
<id>1b46638e39f34ca3cfffdde235db69cd8150d284</id>
<content type='text'>
Previously, the focused window in each tab was the Fugitive window that
contained the old version of the file. It's nicer to have the new
version focused by default, because that allows you to make changes to
the local source code.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, the focused window in each tab was the Fugitive window that
contained the old version of the file. It's nicer to have the new
version focused by default, because that allows you to make changes to
the local source code.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-difftool: Use newer vim-fugitive diff command</title>
<updated>2023-07-25T23:28:37+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-07-25T23:28:37+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=aea58342b68a53c58bd6f14aa9ea8b44d713d368'/>
<id>aea58342b68a53c58bd6f14aa9ea8b44d713d368</id>
<content type='text'>
The Fugitive documentation says that `Gdiff` is deprecated. In the
current version, you need to use the `Gvdiffsplit` command to get a
side-by-side diff with a vertical split.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The Fugitive documentation says that `Gdiff` is deprecated. In the
current version, you need to use the `Gvdiffsplit` command to get a
side-by-side diff with a vertical split.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-difftool: Turn off swap files</title>
<updated>2019-11-07T23:29:46+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-11-07T23:29:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=d691030b0a8b354be0ea158990b3994284502c33'/>
<id>d691030b0a8b354be0ea158990b3994284502c33</id>
<content type='text'>
When the files being opened with `difftool` are already open in a Vim
instance, a 'swap file already exists' confirmation warning is displayed
for each file. Bypass the warning by not saving swap files (using the -n
command line option).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When the files being opened with `difftool` are already open in a Vim
instance, a 'swap file already exists' confirmation warning is displayed
for each file. Bypass the warning by not saving swap files (using the -n
command line option).
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-difftool: Remove `extglob` `shopt` maneuvers</title>
<updated>2019-06-17T18:28:55+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-17T18:28:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=0c7d7544107ca416654cc0dffc7f627da5f07797'/>
<id>0c7d7544107ca416654cc0dffc7f627da5f07797</id>
<content type='text'>
Turns out I don't need to worry about setting or unsetting `extglob` at
all because the script gets executed in a subshell. Obviously. Didn't
realise or test thoroughly at first.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Turns out I don't need to worry about setting or unsetting `extglob` at
all because the script gets executed in a subshell. Obviously. Didn't
realise or test thoroughly at first.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-difftool: Retain old `extglob` setting</title>
<updated>2019-06-17T18:23:28+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-17T18:23:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=ccd5d657bf0550c269c2c3da4925c81fd71e420c'/>
<id>ccd5d657bf0550c269c2c3da4925c81fd71e420c</id>
<content type='text'>
If `extglob` was set, we'd always unset it. Check to see if it's set
before doing anything with it, and then restore it to its original
value.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If `extglob` was set, we'd always unset it. Check to see if it's set
before doing anything with it, and then restore it to its original
value.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-difftool: Remove commented code from 42215fe2bbefba19308bd8</title>
<updated>2019-06-17T18:11:45+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-17T18:11:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=4a97c5b9d9a367916b86db922bc913e99c6b17c0'/>
<id>4a97c5b9d9a367916b86db922bc913e99c6b17c0</id>
<content type='text'>
This was a note preceding implementation, and is no longer needed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was a note preceding implementation, and is no longer needed.
</pre>
</div>
</content>
</entry>
<entry>
<title>get_merge_base(): Change default base to `master...`</title>
<updated>2019-06-17T18:05:47+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-17T18:05:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=42215fe2bbefba19308bd879f6507123d53d1fe1'/>
<id>42215fe2bbefba19308bd879f6507123d53d1fe1</id>
<content type='text'>
Add the range filter to try to remove commits that we don't care about.
Still not sure if this will work in all cases, as sometimes `..` seemed
to give me the right collection of files and sometimes `...` did.

code-review-difftool:
Pass the merge base without range dots (`..` or `...`) to Vim Fugitive,
as it doesn't accept revisions with ranges. Not sure what to do if I get
a range with two revision names yet, though.

Turns on Bash's `extglob` in order to use `?(...)` to include both
patterns in the expansion.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add the range filter to try to remove commits that we don't care about.
Still not sure if this will work in all cases, as sometimes `..` seemed
to give me the right collection of files and sometimes `...` did.

code-review-difftool:
Pass the merge base without range dots (`..` or `...`) to Vim Fugitive,
as it doesn't accept revisions with ranges. Not sure what to do if I get
a range with two revision names yet, though.

Turns on Bash's `extglob` in order to use `?(...)` to include both
patterns in the expansion.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add license (GNU GPLv3+)</title>
<updated>2019-06-10T10:48:33+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-10T10:48:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=3bfeca8f6735e9f614f898af56da29775c47d337'/>
<id>3bfeca8f6735e9f614f898af56da29775c47d337</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-difftool: Remove completed TODOs</title>
<updated>2019-06-10T08:24:07+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2019-06-10T08:24:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=9a4f0738e7da4ae5789e5f7146b02d694758a5bb'/>
<id>9a4f0738e7da4ae5789e5f7146b02d694758a5bb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
