<feed xmlns='http://www.w3.org/2005/Atom'>
<title>code-review, branch master</title>
<subtitle>Tools to facilitate code review on the command line</subtitle>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/'/>
<entry>
<title>code-review-gh-start: Add "origin/" prefix to merge base</title>
<updated>2023-12-08T21:01:20+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-12-08T21:01:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=d0ab1abe75e20dd402734bafa30b0b828905880d'/>
<id>d0ab1abe75e20dd402734bafa30b0b828905880d</id>
<content type='text'>
True, the remote name is not necessarily going to be called "origin",
but that's a reasonable default.

This allows commit ranges to work even when the merge base branch hasn't
been created locally.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
True, the remote name is not necessarily going to be called "origin",
but that's a reasonable default.

This allows commit ranges to work even when the merge base branch hasn't
been created locally.
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright years on recently changed files</title>
<updated>2023-11-24T20:13:22+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T20:13:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=095286de0e4df86706a807d3898cded4adeeb5d5'/>
<id>095286de0e4df86706a807d3898cded4adeeb5d5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-changed-files: Move "..." back to `get_merge_base`</title>
<updated>2023-11-24T20:06:46+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T20:06:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=7232165a08aeb511970b5876c6ea13ee443bfe4d'/>
<id>7232165a08aeb511970b5876c6ea13ee443bfe4d</id>
<content type='text'>
It's more convenient to have the "..." here because all of the
code-review commands use `get_merge_base`. Otherwise I'd end up having
to add it to most of the other commands.

But now, instead of only adding it to the default merge base, add it to
all merge bases, including the one set by `code-review-start`. This
makes all merge bases consistent, and means you don't have to include
the dots when setting a custom merge base.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's more convenient to have the "..." here because all of the
code-review commands use `get_merge_base`. Otherwise I'd end up having
to add it to most of the other commands.

But now, instead of only adding it to the default merge base, add it to
all merge bases, including the one set by `code-review-start`. This
makes all merge bases consistent, and means you don't have to include
the dots when setting a custom merge base.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add 'code-review-ddiff'</title>
<updated>2023-11-24T19:53:14+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T19:53:14+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=bc44e15843b4346c278a1cb169eb8aba81717275'/>
<id>bc44e15843b4346c278a1cb169eb8aba81717275</id>
<content type='text'>
This is inspired by a Git alias I have, `git ddiff`, that opens the Git
diff in the Delta diff viewer (https://github.com/dandavison/delta).
Delta ends up being much nicer than regular Git diff for code reviews
because it renders syntax highlighting.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is inspired by a Git alias I have, `git ddiff`, that opens the Git
diff in the Delta diff viewer (https://github.com/dandavison/delta).
Delta ends up being much nicer than regular Git diff for code reviews
because it renders syntax highlighting.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-database: Add environment variable for merge base</title>
<updated>2023-11-24T19:50:00+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T19:50:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=0cc2afee74cd3025870a091ec57c5709e2c2ce9f'/>
<id>0cc2afee74cd3025870a091ec57c5709e2c2ce9f</id>
<content type='text'>
I was inspired by Jake Zimmerman's blog post "Code Review from the
Command Line" (https://blog.jez.io/cli-code-review/) to add an
environment variable override for the merge base. This allows us to set
a different merge base for individual command executions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I was inspired by Jake Zimmerman's blog post "Code Review from the
Command Line" (https://blog.jez.io/cli-code-review/) to add an
environment variable override for the merge base. This allows us to set
a different merge base for individual command executions.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-stat: Pass arguments to Git</title>
<updated>2023-11-24T19:48:55+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T19:48:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=93719fc0a1c2e11aca1a645efce0e23502054b03'/>
<id>93719fc0a1c2e11aca1a645efce0e23502054b03</id>
<content type='text'>
This allows us to pass along arguments like `--ignore-all-space`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows us to pass along arguments like `--ignore-all-space`.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-difftool: Focus new changes buffer instead of old version</title>
<updated>2023-11-24T19:46:20+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T19:46:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=1b46638e39f34ca3cfffdde235db69cd8150d284'/>
<id>1b46638e39f34ca3cfffdde235db69cd8150d284</id>
<content type='text'>
Previously, the focused window in each tab was the Fugitive window that
contained the old version of the file. It's nicer to have the new
version focused by default, because that allows you to make changes to
the local source code.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, the focused window in each tab was the Fugitive window that
contained the old version of the file. It's nicer to have the new
version focused by default, because that allows you to make changes to
the local source code.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-database: Remove "..." from merge base</title>
<updated>2023-11-24T19:44:18+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-11-24T19:44:18+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=9afec6570dd9795aeb720678cd3b2286d3998a13'/>
<id>9afec6570dd9795aeb720678cd3b2286d3998a13</id>
<content type='text'>
I don't think this is the right approach, but since I added the "..." in
`code-review-changed-files` in 7659cf07f118fec4c1ba9677c82a7ef61511e797,
removing the "..." from here allows the difftool script to work when
using the default merge base.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I don't think this is the right approach, but since I added the "..." in
`code-review-changed-files` in 7659cf07f118fec4c1ba9677c82a7ef61511e797,
removing the "..." from here allows the difftool script to work when
using the default merge base.
</pre>
</div>
</content>
</entry>
<entry>
<title>code-review-changed-files: Add "..." to the merge base</title>
<updated>2023-10-29T23:09:45+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-10-29T23:09:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=7659cf07f118fec4c1ba9677c82a7ef61511e797'/>
<id>7659cf07f118fec4c1ba9677c82a7ef61511e797</id>
<content type='text'>
Doesn't cover all the cases, but I think this should give us the correct
set of files when the merge base has been set via `code-review-start`.
Otherwise we might end up with a bunch of files that came from other
branches, not the one we're reviewing now.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Doesn't cover all the cases, but I think this should give us the correct
set of files when the merge base has been set via `code-review-start`.
Otherwise we might end up with a bunch of files that came from other
branches, not the one we're reviewing now.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'github-merge-base'</title>
<updated>2023-08-08T18:26:49+00:00</updated>
<author>
<name>Teddy Wing</name>
</author>
<published>2023-08-08T18:26:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/code-review/commit/?id=e2dfaa222065257a7ce674b0c1eaf8bd3f9ebdf7'/>
<id>e2dfaa222065257a7ce674b0c1eaf8bd3f9ebdf7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
