From 5933a5ae5fd8decf70e1e49bc2d877441f0e4479 Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Sun, 20 Dec 2020 19:15:15 +0100 Subject: Set `pkg/browser`'s `Stderr` and `Stdout` to ours We need to connect our `Stderr` and `Stdout` to those in `github.com/pkg/browser` so that custom writers get linked correctly in the underlying library. Previously, customising these writers only worked for the command specified in the `BROWSER` environment variable, not when `BROWSER` was unset. --- browserenv_unix_test.go | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) (limited to 'browserenv_unix_test.go') diff --git a/browserenv_unix_test.go b/browserenv_unix_test.go index 069c322..d328290 100644 --- a/browserenv_unix_test.go +++ b/browserenv_unix_test.go @@ -131,3 +131,31 @@ func TestOpenURLMultipleBrowserCommands(t *testing.T) { unsetEnvBrowser(t) } + +func TestOpenFilePkgBrowserUsesStderr(t *testing.T) { + var stderr strings.Builder + Stderr = &stderr + + OpenFile("file:///tmp/does-not-exist") + + got := stderr.String() + if got == "" { + t.Errorf("got empty stderr want an error message") + } + + unsetEnvBrowser(t) +} + +func TestOpenURLPkgBrowserUsesStderr(t *testing.T) { + var stderr strings.Builder + Stderr = &stderr + + OpenURL("file:///tmp/does-not-exist") + + got := stderr.String() + if got == "" { + t.Errorf("got empty stderr want an error message") + } + + unsetEnvBrowser(t) +} -- cgit v1.2.3