From 704b91ca02f87fe0f6d3e059aa2aeb8e3e823c14 Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Sun, 20 Dec 2020 15:30:20 +0100 Subject: Rename `fmtBrowserCommand()` to `escapeBrowserCommand()` Formatting the browser command will incorporate more steps, not just this one, so rename it to be more specific about what it's doing. I want to use the other name for a different function. --- browserenv.go | 2 +- browserenv_unix.go | 2 +- browserenv_windows.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/browserenv.go b/browserenv.go index 4ff70a4..678b651 100644 --- a/browserenv.go +++ b/browserenv.go @@ -82,7 +82,7 @@ func browserCommand(command, url string) *exec.Cmd { if browserCommandIncludesURL(command) { command = fmtWithURL(command, url) } else { - command = fmtBrowserCommand(command, url) + command = escapeBrowserCommand(command, url) } args = append(args, command) diff --git a/browserenv_unix.go b/browserenv_unix.go index e6416f8..d2f9538 100644 --- a/browserenv_unix.go +++ b/browserenv_unix.go @@ -19,7 +19,7 @@ func shell() (args []string) { } // TODO -func fmtBrowserCommand(browser, url string) string { +func escapeBrowserCommand(browser, url string) string { // TODO: handle %s in browser command return fmt.Sprintf("%s '%s'", browser, url) } diff --git a/browserenv_windows.go b/browserenv_windows.go index ef9c2b7..be90ba5 100644 --- a/browserenv_windows.go +++ b/browserenv_windows.go @@ -10,6 +10,6 @@ func shell() (args []string) { } // TODO -func fmtBrowserCommand(browser, url string) string { +func escapeBrowserCommand(browser, url string) string { return fmt.Sprintf("%s %s", browser, url) } -- cgit v1.2.3