From 8778928a0989ea938fb06f0dd4c6639a6f9148ca Mon Sep 17 00:00:00 2001
From: Teddy Wing
Date: Thu, 24 Dec 2015 18:26:03 -0800
Subject: Make hotkey preference work

Separate preference handling into a new class and have the previous
preferences class handle only the preferences window.

We rename the old file to `preferences_window.py` and adjust the
`info.plist` key for the menu item accordingly.

Our new `Preference` class can now be imported from both
`equalize_sidebearings.py` and `preferences_window.py` without causing
confusion. I extracted it because asking for the
`DEFAULT_ACTIVATION_KEY` from `preferences_window.py` from
`equalize_sidebearings.py` would open the preferences window (bad).

We now save the preferred key using RoboFont's extension preferences
API.

When the text input in the preferences window is modified, the new key
preference gets saved.

BUG:
There's an issue with this implementation where the preferred key
doesn't become active until the next launch of RoboFont because
`EqualizeSidebearings` has its own instance of `Preferences` which has a
stale `activation_key`.
---
 info.plist | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'info.plist')

diff --git a/info.plist b/info.plist
index 5278866..3b5c780 100644
--- a/info.plist
+++ b/info.plist
@@ -6,7 +6,7 @@
 	<array>
 		<dict>
 			<key>path</key>
-			<string>preferences.py</string>
+			<string>preferences_window.py</string>
 			<key>preferredName</key>
 			<string>Preferences</string>
 			<key>shortKey</key>
-- 
cgit v1.2.3