diff options
| author | Teddy Wing | 2015-05-24 17:19:40 -0400 | 
|---|---|---|
| committer | Teddy Wing | 2015-05-24 17:19:40 -0400 | 
| commit | ed15eefe0ab87f33d3c3d9e5e2204a7bf508bf70 (patch) | |
| tree | 9c7b36e558cfaffd03f33f672a930092320844b9 | |
| parent | c51f5ade946771a3a5c2398aff4b46bef9e8efe2 (diff) | |
| download | Peniquitous-ed15eefe0ab87f33d3c3d9e5e2204a7bf508bf70.tar.bz2 | |
peniquitous.js: Get rid of key code magic numbers
Move the key code numerical values into a hash so we can refer to them
by name instead of obtuse magic numbers.
| -rw-r--r-- | peniquitous.js | 15 | 
1 files changed, 11 insertions, 4 deletions
| diff --git a/peniquitous.js b/peniquitous.js index 0b64ddd..83aebf2 100644 --- a/peniquitous.js +++ b/peniquitous.js @@ -1,4 +1,11 @@  (function() { +	key_codes = { +		p: 80, +		n: 78, +		UP_ARROW: 38, +		DOWN_ARROW: 40 +	}; +  	// Additional types:  	//   * email  	//   * number @@ -9,11 +16,11 @@  	for (var i = 0; i < all_inputs.length; i++) {  		all_inputs[i].addEventListener('keyup', function(e) { -			if (e.ctrlKey && e.keyCode === 80) { -				KeyEvent.simulate(0, 38, [], e.target); +			if (e.ctrlKey && e.keyCode === key_codes.p) { +				KeyEvent.simulate(0, key_codes.UP_ARROW, [], e.target);  			} -			else if (e.ctrlKey && e.keyCode === 78) { -				KeyEvent.simulate(0, 40, [], e.target); +			else if (e.ctrlKey && e.keyCode === key_codes.n) { +				KeyEvent.simulate(0, key_codes.DOWN_ARROW, [], e.target);  			}  		});  	} | 
