GitHub-Apple-Option-P-to-Preview, branch master A Greasemonkey script that activates Apple-Option-P as a GitHub comment preview shortcut Add copyright notice 2022-07-21T18:53:40+00:00 Teddy Wing 2022-07-21T18:53:29+00:00 60dd527a0454604b6b3acd274e4f66d5b8f116b1 I guess I didn't bother with this when I first wrote the script. 
I guess I didn't bother with this when I first wrote the script.
Increase version v0.0.1 -> v0.0.2 2022-07-20T21:10:10+00:00 Teddy Wing 2022-07-20T21:04:44+00:00 c6cc5b84d530b35cc55610ae2bdc26b5c7f6136c 






Attach key event listener to `<html>` instead of `<body>`
2022-07-20T01:49:28+00:00

Teddy Wing

2022-07-20T01:49:28+00:00

94c30fef65a1beb49e65860c7ed99964e9c162e2

Recently I noticed that sometimes the shortcut didn't work. The CSS
classes and HTML structure didn't change. The shortcut stopped working
after a navigation action. Maybe Turbolinks replaces `<body>` now?
Regardless, attaching the event listener to an element higher in the
tree allows the shortcut to continue working even after navigation.





Recently I noticed that sometimes the shortcut didn't work. The CSS
classes and HTML structure didn't change. The shortcut stopped working
after a navigation action. Maybe Turbolinks replaces `<body>` now?
Regardless, attaching the event listener to an element higher in the
tree allows the shortcut to continue working even after navigation.







Add README
2017-09-28T22:56:15+00:00

Teddy Wing

2017-09-28T22:49:38+00:00

de8013b706108713397158ac0bb0ce8ed32015de

Include a description of the problem and script, installation
instructions, and license information.





Include a description of the problem and script, installation
instructions, and license information.







Add license (GNU GPLv3+)
2017-09-28T22:56:15+00:00

Teddy Wing

2017-09-28T22:29:56+00:00

221c6951a7447b2c588bcb69c150b289efcdefcb












Enable listener for all comment fields including future ones
2017-09-28T22:56:13+00:00

Teddy Wing

2017-09-28T22:22:45+00:00

6e9040f7ef45ef8262cdbebab719cd961c5b1147

The keyboard shortcut now works on all comment fields, including those
that are created after page load.

Thanks to this Stack Overflow answer from 'adeneo' and Suraj Jain:
https://stackoverflow.com/questions/20330945/how-to-addeventlistener-to-future-dom-elements/20331016#20331016

It takes advantage of the fact that JavaScript events bubble. We attach
an event to `<body>`, which we can be sure will always be there (even
across GitHub's Turbolinks), and in the keydown event listener check to
see whether we were called on the right element.





The keyboard shortcut now works on all comment fields, including those
that are created after page load.

Thanks to this Stack Overflow answer from 'adeneo' and Suraj Jain:
https://stackoverflow.com/questions/20330945/how-to-addeventlistener-to-future-dom-elements/20331016#20331016

It takes advantage of the fact that JavaScript events bubble. We attach
an event to `<body>`, which we can be sure will always be there (even
across GitHub's Turbolinks), and in the keydown event listener check to
see whether we were called on the right element.







Add a key event listener to open Preview pane on GitHub comments
2017-09-28T22:10:21+00:00

Teddy Wing

2017-09-28T22:10:21+00:00

a56fc2cdc16929216bea1db71b76641152a9c00b

Use Apple-Option-P to open the preview pane and toggle it closed.

GitHub uses Apple-Shift-P by default to toggle the Preview pane. I need
this new shortcut because Firefox uses Apple-Shift-P to open new private
browsing windows, shadowing it from GitHub.

This is the initial working version of this script. It doesn't currently
support comment fields that are added to the page after page load.





Use Apple-Option-P to open the preview pane and toggle it closed.

GitHub uses Apple-Shift-P by default to toggle the Preview pane. I need
this new shortcut because Firefox uses Apple-Shift-P to open new private
browsing windows, shadowing it from GitHub.

This is the initial working version of this script. It doesn't currently
support comment fields that are added to the page after page load.